[dovecot/core] dfe53c: lmtp: Use port 24 if no port has been provided

GitHub noreply at github.com
Mon Aug 8 08:30:13 UTC 2016 

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: dfe53c824fb6f6e3736ee2958665dd6f545724b1
      https://github.com/dovecot/core/commit/dfe53c824fb6f6e3736ee2958665dd6f545724b1
  Author: Wido den Hollander <wido at widodh.nl>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Use port 24 if no port has been provided

This allows using the LMTP, IMAP and POP3 proxy on the same
Dovecot installation without the userdb providing the port
to connect to.

TCP port 24 is registered at IANA as: "any private mail system"

LMTP being the Local Mail Transfer Protocol classifies as a private
mail system and thus justifies the usage of port 24.

Prior to this patch the LTMP client would connect to TCP port 0 by
default if the userdb did not provide a port to connect to.


  Commit: 0d1d485939b9b7f1a0f588aea40c504e3d26e35b
      https://github.com/dovecot/core/commit/0d1d485939b9b7f1a0f588aea40c504e3d26e35b
  Author: J. Nick Koston <nick at cpanel.net>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/plugins/quota-clone/quota-clone-plugin.c

  Log Message:
  -----------
  quota_clone plugin: quota_clone_mail_user_created warned without debug

"The quota_clone_dict setting is missing from configuration" warning
would be thrown when debug mode was not enabled.  This warning
happens under normal circumstances when prefix="" namespace is not
defined (usually when set to INBOX.)

See http://dovecot.org/list/dovecot-cvs/2012-October/021981.html for
more details on the automagic prefix="" namespace.

This change suppresses the spurious warning.


  Commit: afd6d387ea65843b59fb6051fb567719d2a5279c
      https://github.com/dovecot/core/commit/afd6d387ea65843b59fb6051fb567719d2a5279c
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-settings.c
    M src/doveadm/doveadm-settings.h
    M src/doveadm/doveadm.c
    M src/doveadm/dsync/dsync-brain-mailbox.c
    M src/doveadm/dsync/dsync-brain-private.h
    M src/doveadm/dsync/dsync-brain.c
    M src/doveadm/dsync/dsync-brain.h
    M src/doveadm/dsync/dsync-ibc-stream.c
    M src/doveadm/dsync/dsync-mail.h
    M src/doveadm/dsync/dsync-mailbox-import.c
    M src/doveadm/dsync/dsync-mailbox-import.h

  Log Message:
  -----------
  dsync: Add support for features

Add empty_header_workaround as first feature


  Commit: 17fbd200b78112bd0d89e89598aa01cea72a74e5
      https://github.com/dovecot/core/commit/17fbd200b78112bd0d89e89598aa01cea72a74e5
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lib-dcrypt/Makefile.am
    R src/lib-dcrypt/dcrypt-iostream-private.h
    A src/lib-dcrypt/dcrypt-iostream.h
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/ostream-encrypt.c
    M src/lib-dcrypt/ostream-encrypt.h
    M src/lib-dcrypt/test-crypto.c
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  lib-dcrypt: add dcrypt-iostream.h

Move everything from dcrypt-iostream-private.h and enum
io_stream_encrypt_flags to the new dcrypt-iostream.h file.


  Commit: ebd1c50bc43e08ee0a05ad68c7d48497a1563fab
      https://github.com/dovecot/core/commit/ebd1c50bc43e08ee0a05ad68c7d48497a1563fab
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/istream-decrypt.h

  Log Message:
  -----------
  lib-dcrypt: make decrypt_istream format and flags visible


  Commit: ceee39b0d2f8f5705b05cccb010c764e9771a9bc
      https://github.com/dovecot/core/commit/ceee39b0d2f8f5705b05cccb010c764e9771a9bc
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M doc/man/doveadm-dump.1.in
    M src/doveadm/Makefile.am
    A src/doveadm/doveadm-dump-dcrypt-file.c
    M src/doveadm/doveadm-dump.c
    M src/doveadm/doveadm-dump.h

  Log Message:
  -----------
  doveadm: add doveadm dump dcrypt-file


  Commit: 0e0a294cfa87a8e44f29997cac48fd5030767b2b
      https://github.com/dovecot/core/commit/0e0a294cfa87a8e44f29997cac48fd5030767b2b
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lib-test/test-common.c
    M src/lib-test/test-common.h
    M src/lib/test-failures.c

  Log Message:
  -----------
  lib-test: improve expected error handling

If we expect a specific error string, then when we see it, suppress it.

We do not suppress errors expected by count, because if we get unexpected
errors, then we do not want them suppressed, and we have no way of
distinguishing between the expected and unexpected errors.

This of course favours the use of the expected string version of the helper,
but alas that's not always usable, as you can only expect one at a time.

Additionally, if we failed to see an expected message, then when we no longer
expect to see it, reset the expected message state to not cascade further
test assertion failures.

Signed-off-by: Phil Carmody <phil at dovecot.fi>

Conflicts:
	src/lib-test/test-common.c


  Commit: d48ce437e36df095b4c8299d84d6eeb20c280994
      https://github.com/dovecot/core/commit/d48ce437e36df095b4c8299d84d6eeb20c280994
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lib-test/test-common.c
    M src/lib-test/test-common.h

  Log Message:
  -----------
  lib-test: enable naming of tests, such that only a subset is run

How to use these will become clear in a subsequent patch. Even if you
don't want to name tests, the macros can reduce redundancy in the code,
as the list of test function prototypes and the list of test functions
to call become the same lists, expanded through 2 different macros.

Signed-off-by: Phil Carmody <phil at dovecot.fi>


  Commit: 6335b1be387359ac461b0c34087bbba98a925a49
      https://github.com/dovecot/core/commit/6335b1be387359ac461b0c34087bbba98a925a49
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M .gitignore
    M src/lib/Makefile.am
    M src/lib/test-lib.c
    M src/lib/test-lib.h
    A src/lib/test-lib.inc

  Log Message:
  -----------
  lib: tests - give the tests names, using the new macros

The lists of test function declarations and of test functions to call was
basically the same list. Use the new test macros to squash them into one
list, and then chose to name all the tests, so that you can select which
ones to run. This can simplify the debug cycle when some of the tests are
lengthy.

e.g.:
  phil at phil:~/repos/dovecot-core$ src/lib/test-lib --match crc
  crc32 ................................................................ : ok
  0 / 1 tests failed

src/lib is clearly the most complicated case, conversions of others where
filtering would be useful should be trivial following this example.

Signed-off-by: Phil Carmody <phil at dovecot.fi>


Compare: https://github.com/dovecot/core/compare/0b9667003a1d...6335b1be3873

More information about the dovecot-cvs mailing list