[dovecot/core] 25c214: doveadm: Extra safety - initialize cmd_input_fd to...

GitHub noreply at github.com
Mon Aug 8 17:00:15 UTC 2016


  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 25c21471977f9ff0cdd8e6882904b78c7d5834b5
      https://github.com/dovecot/core/commit/25c21471977f9ff0cdd8e6882904b78c7d5834b5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Extra safety - initialize cmd_input_fd to -1

Just to be sure it's never attempted to be accessed as 0 (stdin) before
being initialized. (It didn't happen with current code as far as I know.)


  Commit: eed4d7d845b48d60ea3746bfae0c35b025f637d5
      https://github.com/dovecot/core/commit/eed4d7d845b48d60ea3746bfae0c35b025f637d5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-save.c

  Log Message:
  -----------
  doveadm: Removed unused code.


  Commit: 9411a15cc6abffc4056e0926e4abe77e18940922
      https://github.com/dovecot/core/commit/9411a15cc6abffc4056e0926e4abe77e18940922
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/lib-auth/auth-master.c

  Log Message:
  -----------
  lib-auth: Avoid crash after user iteration if connection failed.


  Commit: a0e641d16049bf5df65f18164f70bf842ab394a2
      https://github.com/dovecot/core/commit/a0e641d16049bf5df65f18164f70bf842ab394a2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Revert earlier NUL-printing change 793b024bf.

It changes the output in ways that are a bit difficult to fix. Also the
the important part where NULs printing is useful is in a message body,
which should work even without this change. So for now just revert it.


  Commit: efb991a2e005ca19c44867f3865ac24a340ec3b7
      https://github.com/dovecot/core/commit/efb991a2e005ca19c44867f3865ac24a340ec3b7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm-server: Fixed potential hang when reading replies to multiple commands


  Commit: fb163f4a440e104154f2fbb0df6cfbf9783ed555
      https://github.com/dovecot/core/commit/fb163f4a440e104154f2fbb0df6cfbf9783ed555
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Avoid recursively calling server input callback

Probably doesn't fix anything, but it could cause confusing backtraces at
least.


  Commit: 10e1efd5fd11ab094289265bd2e06bea42931732
      https://github.com/dovecot/core/commit/10e1efd5fd11ab094289265bd2e06bea42931732
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Fixed hanging when printing output from different server connections.


  Commit: 14da98f02094dcef9ee5a051aedaf4b221367d29
      https://github.com/dovecot/core/commit/14da98f02094dcef9ee5a051aedaf4b221367d29
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mail.h

  Log Message:
  -----------
  doveadm: Fixed -A and -u wildcard handling with server connections.


Compare: https://github.com/dovecot/core/compare/4a4f7ff387af...14da98f02094


More information about the dovecot-cvs mailing list