[dovecot/pigeonhole] b800fc: lib-managesieve: managesieve-parser: Fixed functio...

Fri Aug 26 00:11:19 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: b800fc1cf24d8210d1512873318caa7638ca95c6
      https://github.com/dovecot/pigeonhole/commit/b800fc1cf24d8210d1512873318caa7638ca95c6
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-managesieve/managesieve-parser.c

  Log Message:
  -----------
  lib-managesieve: managesieve-parser: Fixed function return types to be bool rather than int.

Found with clang -Wstrict-bool.

  Commit: 02d0b7ffcae32fd26c988b4f68addeb396fde8c9
      https://github.com/dovecot/pigeonhole/commit/02d0b7ffcae32fd26c988b4f68addeb396fde8c9
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/ext-encoded-character.c

  Log Message:
  -----------
  lib-sieve: encoded-character extension: Fixed function return types to be bool rather than int.

Found with clang -Wstrict-bool.

  Commit: 5ef69ddc0068e7d06f9b8d1c1c0bec5cc15a3872
      https://github.com/dovecot/pigeonhole/commit/5ef69ddc0068e7d06f9b8d1c1c0bec5cc15a3872
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/mcht-contains.c
    M src/lib-sieve/mcht-is.c
    M src/lib-sieve/mcht-matches.c

  Log Message:
  -----------
  lib-sieve: match types: Fixed match function return values to be int rather than bool.

Found with clang -Wstrict-bool.

  Commit: dc60b279ee66455f737e0e054f7c41e5574ee085
      https://github.com/dovecot/pigeonhole/commit/dc60b279ee66455f737e0e054f7c41e5574ee085
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/enotify/cmd-notify.c
    M src/lib-sieve/plugins/enotify/ext-enotify-common.c
    M src/lib-sieve/plugins/enotify/mailto/ntfy-mailto.c
    M src/lib-sieve/plugins/enotify/mailto/uri-mailto.c
    M src/lib-sieve/plugins/enotify/vmodf-encodeurl.c

  Log Message:
  -----------
  lib-sieve: enotify extension: Fixed various bool vs. int/pointer mixups.

Found with clang -Wstrict-bool.

  Commit: 13485c3331301e0b30d7b6e90a905f7ffe7787aa
      https://github.com/dovecot/pigeonhole/commit/13485c3331301e0b30d7b6e90a905f7ffe7787aa
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/include/cmd-include.c
    M src/lib-sieve/plugins/include/ext-include-common.c

  Log Message:
  -----------
  lib-sieve: include extension: Fixed various bool vs. int mixups.

Found with clang -Wstrict-bool.

  Commit: e180373fac0c2fb73909bedf9889b7594fb9b7c6
      https://github.com/dovecot/pigeonhole/commit/e180373fac0c2fb73909bedf9889b7594fb9b7c6
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/index/tag-index.c

  Log Message:
  -----------
  lib-sieve: index extension: Fixed a bool vs. int mixup.

Found with clang -Wstrict-bool.

  Commit: 01f7d9f3b2d107c366e626d4bf4f38b6cd20b62d
      https://github.com/dovecot/pigeonhole/commit/01f7d9f3b2d107c366e626d4bf4f38b6cd20b62d
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/mailbox/tst-mailboxexists.c

  Log Message:
  -----------
  lib-sieve: mailbox extension: Fixed invalid use of sieve_ast_stringlist_map().

Mixed up bool and int return types.
Found with clang -Wstrict-bool.

  Commit: f95c6c0cf3a15647315b7938fda37cca5b29ccb4
      https://github.com/dovecot/pigeonhole/commit/f95c6c0cf3a15647315b7938fda37cca5b29ccb4
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/metadata/tst-metadataexists.c

  Log Message:
  -----------
  lib-sieve: metadata extension: Fixed invalid use of sieve_ast_stringlist_map().

Mixed up bool and int return types.
Found with clang -Wstrict-bool.

  Commit: dabacd9ad483890f21d955a3128c5c506e4785f5
      https://github.com/dovecot/pigeonhole/commit/dabacd9ad483890f21d955a3128c5c506e4785f5
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/notify/cmd-notify.c

  Log Message:
  -----------
  lib-sieve: deprecated notify extension: Fixed various bool vs. int/pointer mixups.

Found with clang -Wstrict-bool.

  Commit: d2fa7208096d19a35efa7cad5988099a5914d33a
      https://github.com/dovecot/pigeonhole/commit/d2fa7208096d19a35efa7cad5988099a5914d33a
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/regex/mcht-regex.c

  Log Message:
  -----------
  lib-sieve: regex extension: Fixed invalid use of sieve_ast_stringlist_map().

Mixed up bool and int return types.
Found with clang -Wstrict-bool.

  Commit: d8331c811a46355338cb6593b0ba532ad5e457f4
      https://github.com/dovecot/pigeonhole/commit/d8331c811a46355338cb6593b0ba532ad5e457f4
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/plugins/vacation/cmd-vacation.c

  Log Message:
  -----------
  lib-sieve: vacation extension: Fixed invalid evaluation of the mail_get_headers() return value.

Found with clang -Wstrict-bool.

  Commit: ae2554949072059be6b22b5037f8ed4419470719
      https://github.com/dovecot/pigeonhole/commit/ae2554949072059be6b22b5037f8ed4419470719
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/ext-reject.c
    M src/lib-sieve/sieve-actions.c
    M src/lib-sieve/sieve-actions.h

  Log Message:
  -----------
  lib-sieve: reject extension: Fixed varius bool vs. int mixups.

Found with clang -Wstrict-bool.

  Commit: 86eb7c956c63a409dcb030ef6b691179dc8f5099
      https://github.com/dovecot/pigeonhole/commit/86eb7c956c63a409dcb030ef6b691179dc8f5099
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/testsuite/cmd-test-message.c
    M src/testsuite/testsuite-binary.c
    M src/testsuite/testsuite-script.c

  Log Message:
  -----------
  testsuite: Fixed various bool vs. int mixups.

Found with clang -Wstrict-bool.

  Commit: 6a6f7309c686ad0e660ca51fdead1a2368aa61dc
      https://github.com/dovecot/pigeonhole/commit/6a6f7309c686ad0e660ca51fdead1a2368aa61dc
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/sieve-tools/sieve-filter.c

  Log Message:
  -----------
  sieve-filter: Fixed a bool vs. int mixup.

Found with clang -Wstrict-bool.

  Commit: b0b9e0a58b0d81c757c96ef258492f4e11e9f79f
      https://github.com/dovecot/pigeonhole/commit/b0b9e0a58b0d81c757c96ef258492f4e11e9f79f
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/sieve-script-private.h
    M src/lib-sieve/storage/dict/sieve-dict-script.c
    M src/lib-sieve/storage/ldap/sieve-ldap-script.c

  Log Message:
  -----------
  lib-sieve: script: The return type of binary_dump_metadata() is supposed to be bool rather than int.

Found with clang -Wstrict-bool.

  Commit: a010c3905bdf8a74747491a17dc1722c6561019a
      https://github.com/dovecot/pigeonhole/commit/a010c3905bdf8a74747491a17dc1722c6561019a
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/sieve-actions.c
    M src/lib-sieve/sieve-actions.h
    M src/lib-sieve/sieve-types.h
    M src/plugins/imapsieve/imap-sieve.c
    M src/plugins/lda-sieve/lda-sieve-plugin.c
    M src/sieve-tools/sieve-test.c

  Log Message:
  -----------
  lib-sieve: The return type of duplicate_check() is supposed to be bool rather than int.

Found with clang -Wstrict-bool.

  Commit: 8e0367b01cc0f81e9c41631da1b171f2b61de3c3
      https://github.com/dovecot/pigeonhole/commit/8e0367b01cc0f81e9c41631da1b171f2b61de3c3
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/storage/file/sieve-file-storage-active.c

  Log Message:
  -----------
  lib-sieve: file storage: The try_hardlink parameter of file_copy() is of type bool, rather than int.

Found with clang -Wstrict-bool.

  Commit: ee3a6554b7ad62daad6ca5d0ccd60e4f712d0e13
      https://github.com/dovecot/pigeonhole/commit/ee3a6554b7ad62daad6ca5d0ccd60e4f712d0e13
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/util/program-client.c

  Log Message:
  -----------
  lib-sieve: util: program-client: Fixed a bool vs. int/pointer mixup.

Found with clang -Wstrict-bool.

  Commit: ec02e3b5cba33d0bea458d4c94397ebb7a46bd02
      https://github.com/dovecot/pigeonhole/commit/ec02e3b5cba33d0bea458d4c94397ebb7a46bd02
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  managesieve: Fixed various bool vs. int mixups.

Found with clang -Wstrict-bool.

  Commit: 0929a40078c3413999ec91aa380013124fb496e0
      https://github.com/dovecot/pigeonhole/commit/0929a40078c3413999ec91aa380013124fb496e0
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/plugins/sieve-extprograms/cmd-execute.c
    M src/plugins/sieve-extprograms/cmd-filter.c
    M src/plugins/sieve-extprograms/sieve-extprograms-common.c

  Log Message:
  -----------
  extprograms plugin: Fixed various bool vs. int mixups.

Found with clang -Wstrict-bool.

  Commit: cab5eff76af5712cc43ecd8adb0bc4d3bb870887
      https://github.com/dovecot/pigeonhole/commit/cab5eff76af5712cc43ecd8adb0bc4d3bb870887
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/plugins/doveadm-sieve/doveadm-sieve-cmd.c
    M src/plugins/doveadm-sieve/doveadm-sieve-cmd.h

  Log Message:
  -----------
  doveadm sieve plugin: Removed unused 'subscriptions' field from command context.

Addresses a FIXME.
Caused a warning with clang -Wstrict-bool.

  Commit: 930ec524c91ccf85e6b3b502e407f74a5bb63643
      https://github.com/dovecot/pigeonhole/commit/930ec524c91ccf85e6b3b502e407f74a5bb63643
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/mcht-is.c
    M src/lib-sieve/sieve-address-parts.c
    M src/lib-sieve/sieve-address.c
    M src/lib-sieve/sieve-binary-file.c
    M src/lib-sieve/sieve-binary.c
    M src/lib-sieve/sieve-code.c
    M src/lib-sieve/sieve-commands.c
    M src/lib-sieve/sieve-parser.c
    M src/lib-sieve/sieve-result.c
    M src/lib-sieve/sieve-storage.c
    M src/lib-sieve/sieve-stringlist.c
    M src/lib-sieve/sieve.c
    M src/lib-sieve/tst-exists.c

  Log Message:
  -----------
  lib-sieve: Fixed various bool vs. int/pointer mixups.

Found with clang -Wstrict-bool.

  Commit: 8a2ef99dba921507a0314c8296085f2264b18492
      https://github.com/dovecot/pigeonhole/commit/8a2ef99dba921507a0314c8296085f2264b18492
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M src/lib-sieve/storage/ldap/sieve-ldap-storage-settings.c

  Log Message:
  -----------
  lib-sieve: ldap storage: Fixed bool vs. int mixup in function call.

Found with clang -Wstrict-bool.

Compare: https://github.com/dovecot/pigeonhole/compare/af91dd3f2d78...8a2ef99dba92