[dovecot/core] 4313a5: doveadm: Fix typos in error messages

Wed Mar 30 12:50:31 UTC 2016

  Branch: refs/heads/release-2.2.23
  Home:   https://github.com/dovecot/core
  Commit: 4313a5bc7b8bacd721586b2fecfabd372c8c3763
      https://github.com/dovecot/core/commit/4313a5bc7b8bacd721586b2fecfabd372c8c3763
  Author: Michael M Slusarz <michael.slusarz at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c

  Log Message:
  -----------
  doveadm: Fix typos in error messages

  Commit: 43ed7f92e7d907de594ebf324b9d1ccc257d438d
      https://github.com/dovecot/core/commit/43ed7f92e7d907de594ebf324b9d1ccc257d438d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/lib/istream-concat.c

  Log Message:
  -----------
  lib: Small code cleanup to istream-concat - don't use a magic UINT_MAX value as error code

  Commit: aea44e1dc4f2d1f8a2dbe05af839c220ae79aeba
      https://github.com/dovecot/core/commit/aea44e1dc4f2d1f8a2dbe05af839c220ae79aeba
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/lib/istream-concat.c

  Log Message:
  -----------
  lib: Avoid assert-crash in istream-concat at close.

If stream was seeked to EOF, cur_input=NULL and closing the stream would cause
i_stream_concat_skip() to crash. Fixed this by making sure cur_input is never NULL.
This also adds a check to not allow seeking past EOF, but this shouldn't happen anyway.

  Commit: 9112e6de550656e2434e05e705d15887e6d4df93
      https://github.com/dovecot/core/commit/9112e6de550656e2434e05e705d15887e6d4df93
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Getting user from USER environment wasn't done in the right place.

doveadm_mail_cmdline_init() is also called when parsing commands from
doveadm-server. The USER environment is supposed to be read only from
doveadm command line.

  Commit: 102279b2a21c5c8ac08bba05f3344aef8d976d0a
      https://github.com/dovecot/core/commit/102279b2a21c5c8ac08bba05f3344aef8d976d0a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/client-connection.c

  Log Message:
  -----------
  doveadm-server: Fixed initializing username for mail commands.

  Commit: 1cccb7f8d5a3b2e927200a8ce7c248c70ef3793f
      https://github.com/dovecot/core/commit/1cccb7f8d5a3b2e927200a8ce7c248c70ef3793f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Move getenv to correct place

All getenv()s must be done after master_service_init() or the pointer will be
corrupted with Linux and other OSes without setproctitle().

  Commit: d592ce4c5648baf21d09819832a2f028a728fa81
      https://github.com/dovecot/core/commit/d592ce4c5648baf21d09819832a2f028a728fa81
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Fixed user weakness getting stuck if multiple directors set user weak simultaneously

  Commit: c5274b7f42ae2a83e75526293bc06826c03fe5d6
      https://github.com/dovecot/core/commit/c5274b7f42ae2a83e75526293bc06826c03fe5d6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director.c
    M src/director/director.h

  Log Message:
  -----------
  director: Don't re-send SYNC unnecessarily often.

  Commit: 0d4a1621f74698a2d5a008d2a2bf5ecb57978749
      https://github.com/dovecot/core/commit/0d4a1621f74698a2d5a008d2a2bf5ecb57978749
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/director-test.sh

  Log Message:
  -----------
  director: Small improvements to director-test.sh

Test with a bigger director ring. Include microseconds in log timestamps to
make debugging easier. Changed the name of the info_log_path.

  Commit: 6e06d93ebd252b66c966c4dc1cd1479ffcb1021f
      https://github.com/dovecot/core/commit/6e06d93ebd252b66c966c4dc1cd1479ffcb1021f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Make sure a long-delayed kill reply for user doesn't mess up the state.

This should fix assert-crash:

director: Panic: file director.c: line 690 (director_user_kill_finish_delayed_to): assertion failed: (ctx->user->kill_state == USER_KILL_STATE_DELAY)

  Commit: c3b5e55cc1e2c54e0e843cdb67f32d7bf2d2bda5
      https://github.com/dovecot/core/commit/c3b5e55cc1e2c54e0e843cdb67f32d7bf2d2bda5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Fixed memory leak when killing a user.

  Commit: 6f84e4f1b6e4531f1ed3a1c5494fbe086381226a
      https://github.com/dovecot/core/commit/6f84e4f1b6e4531f1ed3a1c5494fbe086381226a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/director/user-directory.c

  Log Message:
  -----------
  director: Make sure freeing a user doesn't leak a timeout.

  Commit: bbbf8a9b7eb491b54b4720d1ff7fe8aebdc63428
      https://github.com/dovecot/core/commit/bbbf8a9b7eb491b54b4720d1ff7fe8aebdc63428
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/lib-http/http-client-peer.c

  Log Message:
  -----------
  lib-http: client: Fixed handling of stalled connections that emerge when the client ioloop hasn't run for a long time.

Inside the peer's request handler routine, the connections are verified
after the ioloop continues. If they turn out to be broken, they
self-destruct while the handler routine is active, leading to problems.

Solved by referencing the connection and retrying the connection statistics
loop when a connection is lost in the process.

  Commit: b291fa30b08ee96e67a47a49ef5850c0a839a63c
      https://github.com/dovecot/core/commit/b291fa30b08ee96e67a47a49ef5850c0a839a63c
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-private.h
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: client: Fixed request timeout handling during pipelining.

The timeout was not managed correctly. If an earlier request finished, it
would not restart the timeout for the next pending request.

Also, filling the pipeline caused the timout to be reset inappropriately,
postponing its expiry.

  Commit: 4e92ade26d79b063b9d6027942fd280547309346
      https://github.com/dovecot/core/commit/4e92ade26d79b063b9d6027942fd280547309346
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm.c

  Log Message:
  -----------
  doveadm: Code cleanup - always use const char *const[] type for argv.

Needed to fix compiler warnings in the following patch.

  Commit: 8a0f558d9ad0d14873cf61fef932ebe7d5924900
      https://github.com/dovecot/core/commit/8a0f558d9ad0d14873cf61fef932ebe7d5924900
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-cmd.h
    M src/doveadm/doveadm-mail-batch.c

  Log Message:
  -----------
  doveadm-server: Fixed running multi-word commands.

The problem with for example "mailbox status" command is that:
 - doveadm cli: argv[0] = "mailbox", argv[1] = "status"
 - doveadm-server: argv[0] = "mailbox status"

So with doveadm cli we'll now instead just skip over words until argv[0]
is the last word of the command ("status").

  Commit: d9fa0b95bcc29b6005e0b500f281be5776321a9f
      https://github.com/dovecot/core/commit/d9fa0b95bcc29b6005e0b500f281be5776321a9f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm-server: v2 mail commands weren't doing a userdb lookup.

  Commit: bbf669412bcbe00abc388c2e8ee2ebb87b6249b4
      https://github.com/dovecot/core/commit/bbf669412bcbe00abc388c2e8ee2ebb87b6249b4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Fixed adding username header to commands iterating through multiple users.

  Commit: 593b0963e92e7edf430664697de864a57b0116e9
      https://github.com/dovecot/core/commit/593b0963e92e7edf430664697de864a57b0116e9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-batch.c

  Log Message:
  -----------
  doveadm-batch: Fixed error message for an unknown subcommand.

  Commit: b32d1954d4774ab9e3fa5854c5279e714c6402f5
      https://github.com/dovecot/core/commit/b32d1954d4774ab9e3fa5854c5279e714c6402f5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-29 (Tue, 29 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm: Fixed reading USER environment for v1 commands.

  Commit: 128216edbfb4bbf58cbabd0c77e78c87c2c47407
      https://github.com/dovecot/core/commit/128216edbfb4bbf58cbabd0c77e78c87c2c47407
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Avoid a potential assert-crash after removing a director from ring.

This should fix the crash:
Panic: director: file director-connection.c: line 1926 (director_connection_init_out): assertion failed: (!host->removed)

Also moved the last_network_failure timestamp reset a bit later, since
there's no need to reset the timestamp if we're not actually connecting
to the server.

  Commit: 7b52bed03be40d60e11f29628be4f6234cd3a082
      https://github.com/dovecot/core/commit/7b52bed03be40d60e11f29628be4f6234cd3a082
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm-mail: Don't lose rip/lip/lport/rport in passdb lookups for doveadm TCP connections

  Commit: edc8b271e8b49d1bda92945cbe287ca1eac0d09a
      https://github.com/dovecot/core/commit/edc8b271e8b49d1bda92945cbe287ca1eac0d09a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
    M src/lib-storage/mailbox-attribute.c

  Log Message:
  -----------
  lib-storage: Fixed memory leak when iterating attributes.

  Commit: 85f3b563e8f8ad5a52bafabc756a760602b4df9e
      https://github.com/dovecot/core/commit/85f3b563e8f8ad5a52bafabc756a760602b4df9e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
    M src/doveadm/doveadm-mail.c

  Log Message:
  -----------
  doveadm-mail: Initialize missing cmd context username

Fixes assert-crash in doveadm_mail_single_user()

  Commit: e253a86e683f0c9d9960984efc308fb7d97a48d6
      https://github.com/dovecot/core/commit/e253a86e683f0c9d9960984efc308fb7d97a48d6
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-03-30 (Wed, 30 Mar 2016)

  Changed paths:
    M NEWS
    M configure.ac

  Log Message:
  -----------
  Released v2.2.23

Compare: https://github.com/dovecot/core/compare/4313a5bc7b8b^...e253a86e683f