[dovecot/core] 7c3a80: lib: var_expand() code cleanup - Moved short %v ex...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 7c3a801caa8daa9a7f57e61b4d1e63f02a51e7e4
      https://github.com/dovecot/core/commit/7c3a801caa8daa9a7f57e61b4d1e63f02a51e7e4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M src/lib/var-expand.c

  Log Message:
  -----------
  lib: var_expand() code cleanup - Moved short %v expansion to its own function.


  Commit: d5e68154e67819140e513cbd037eda9c1b929c4e
      https://github.com/dovecot/core/commit/d5e68154e67819140e513cbd037eda9c1b929c4e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M src/auth/passdb-passwd-file.c
    M src/auth/userdb-passwd-file.c

  Log Message:
  -----------
  auth: Code cleanup - Move passwd-file extra fields import to its own function.

This will shrink the diff output for the following var_expand() change.


  Commit: 0f5dc4da3982053036be65190e44bf28a67b1ca2
      https://github.com/dovecot/core/commit/0f5dc4da3982053036be65190e44bf28a67b1ca2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M src/auth/auth-cache.c
    M src/auth/auth-policy.c
    M src/auth/auth-request-var-expand.c
    M src/auth/auth-request-var-expand.h
    M src/auth/auth-request.c
    M src/auth/db-checkpassword.c
    M src/auth/db-dict.c
    M src/auth/db-ldap.c
    M src/auth/db-passwd-file.c
    M src/auth/passdb-imap.c
    M src/auth/passdb-ldap.c
    M src/auth/passdb-pam.c
    M src/auth/passdb-passwd-file.c
    M src/auth/passdb-sql.c
    M src/auth/passdb-static.c
    M src/auth/passdb-template.c
    M src/auth/passdb-template.h
    M src/auth/test-auth-cache.c
    M src/auth/test-auth-request-var-expand.c
    M src/auth/userdb-dict.c
    M src/auth/userdb-ldap.c
    M src/auth/userdb-passwd-file.c
    M src/auth/userdb-passwd.c
    M src/auth/userdb-sql.c
    M src/auth/userdb-static.c
    M src/auth/userdb-template.c
    M src/auth/userdb-template.h
    M src/director/director-request.c
    M src/director/director.c
    M src/director/doveadm-connection.c
    M src/director/notify-connection.c
    M src/director/test-user-directory.c
    M src/director/user-directory.c
    M src/director/user-directory.h
    M src/doveadm/doveadm-auth-server.c
    M src/doveadm/doveadm-auth.c
    M src/doveadm/doveadm-director.c
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-print-formatted.c
    M src/imap-hibernate/imap-client.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/imap-client.c
    M src/imap/main.c
    M src/lda/main.c
    M src/lib-lda/mail-deliver.c
    M src/lib-lda/mail-send.c
    M src/lib-mail/mail-user-hash.c
    M src/lib-mail/mail-user-hash.h
    M src/lib-settings/settings-parser.c
    M src/lib-settings/settings-parser.h
    M src/lib-sql/driver-cassandra.c
    M src/lib-storage/index/shared/shared-storage.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-user.c
    M src/lib/test-var-expand.c
    M src/lib/var-expand.c
    M src/lib/var-expand.h
    M src/lmtp/client.c
    M src/lmtp/commands.c
    M src/login-common/client-common.c
    M src/login-common/login-proxy.c
    M src/login-common/login-settings.c
    M src/plugins/acl/acl-shared-storage.c
    M src/plugins/dict-ldap/dict-ldap.c
    M src/pop3/pop3-client.c
    M src/pop3/pop3-commands.c

  Log Message:
  -----------
  lib: API change - var_expand*() now returns error string.

This allows callers to fail properly if the format string is invalid.


  Commit: bcf1cf2afb9692b0db555e6ecf662a2fbd19793d
      https://github.com/dovecot/core/commit/bcf1cf2afb9692b0db555e6ecf662a2fbd19793d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-02 (Wed, 02 Nov 2016)

  Changed paths:
    M src/auth/auth-request-var-expand.c
    M src/auth/db-dict.c
    M src/auth/db-ldap.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-user.c
    M src/lib/test-var-expand.c
    M src/lib/var-expand.c
    M src/lib/var-expand.h
    M src/login-common/client-common.c

  Log Message:
  -----------
  lib: API change - var_expand_func_table.func() can now return error.

None of the existing functions were changed to return errors (yet).


Compare: https://github.com/dovecot/core/compare/d2fd204b303e...bcf1cf2afb96