[dovecot/core] 08923d: lib-master: Make sure stdin/stdout/stderr fds are ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 08923d2c956ece3dc604d5842ba152c2bdb11fb9
      https://github.com/dovecot/core/commit/08923d2c956ece3dc604d5842ba152c2bdb11fb9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-14 (Mon, 14 Nov 2016)

  Changed paths:
    M src/lib-master/master-service.c

  Log Message:
  -----------
  lib-master: Make sure stdin/stdout/stderr fds are open.

We'll just open /dev/null for them if they don't already exist.


  Commit: 5a0b58bfcf65991a5b99cc84438815601d56377c
      https://github.com/dovecot/core/commit/5a0b58bfcf65991a5b99cc84438815601d56377c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-14 (Mon, 14 Nov 2016)

  Changed paths:
    M src/master/main.c

  Log Message:
  -----------
  master: Remove redundant check to guarantee stdin/stdout/stderr fd existence.

The previous method also wasn't correct, since it was setting close-on-exec
flag for the fds. Although this didn't normally make any difference, since
stdin & stdout was explicitly dup2()ed to /dev/null and for all except the
log process stderr was also being dup2()ed.


  Commit: 8638c3723e3d4dfe921d0f8a1fc844a9ed79d5d3
      https://github.com/dovecot/core/commit/8638c3723e3d4dfe921d0f8a1fc844a9ed79d5d3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-14 (Mon, 14 Nov 2016)

  Changed paths:
    M src/lib/macros.h

  Log Message:
  -----------
  lib: Assert-crash in i_close_fd() if fd == 0

lib-master now guarantees that fd==0 doesn't normally happen.


Compare: https://github.com/dovecot/core/compare/a85c629c5d75...8638c3723e3d