[dovecot/core] 323d03: lib-index: Handle invalid headers as "corruption",...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 323d035fb645850fd12f67f1dbf31e1d741925f2
      https://github.com/dovecot/core/commit/323d035fb645850fd12f67f1dbf31e1d741925f2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/lib-index/mail-index-map-hdr.c
    M src/lib-index/mail-index-map-read.c

  Log Message:
  -----------
  lib-index: Handle invalid headers as "corruption", not "temporary error"

This is especially required for "Header's corrupted flag is set" error,
which won't get fixed otherwise.

It's a bit more questionable if we should treat major version or CPU
architecture change as corruption, but it's possible those only exist
because of corruption. It's also very unlikely that either is really
happening. Ideally there would be a hash that verifies whether the
header is corrupted or not.


  Commit: 3b27e2706d7b54da44955760a140f3117e742625
      https://github.com/dovecot/core/commit/3b27e2706d7b54da44955760a140f3117e742625
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/lib-fts/test-fts-tokenizer.c

  Log Message:
  -----------
  lib-fts: Fix fts_tokenizer_delete_trailing_partial_char() unit test


  Commit: 8c4b4b9c61f098dc8bf2707d605d9ecdc60fe03d
      https://github.com/dovecot/core/commit/8c4b4b9c61f098dc8bf2707d605d9ecdc60fe03d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/lib-fts/fts-tokenizer-address.c
    M src/lib-fts/test-fts-tokenizer.c

  Log Message:
  -----------
  lib-fts: Make sure address tokenizer can't return empty tokens.

This happened when address was a token that first looked like it could be
a valid address, but then got truncated due to reaching maxlen, followed
by truncating the UTF8-sequence and finally all the rest of the '-' or
'.' chars that were valid at the beginning of the address are stripped
away by fts_tokenizer_delete_trailing_invalid_char(), leaving nothing left.

Fixes:
Panic: file fts-tokenizer.c: line 206 (fts_tokenizer_next): assertion failed: (ret <= 0 || (*token_r)[0] != '\0')


  Commit: 988ff60eb9c405b84dafd1a56d35a014e24e9a77
      https://github.com/dovecot/core/commit/988ff60eb9c405b84dafd1a56d35a014e24e9a77
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/lib-fts/test-fts-tokenizer.c

  Log Message:
  -----------
  lib-fts: Add randomness test to test-fts-tokenizer


  Commit: 1df777483912319a01110df6f8f48d1e84ff92ad
      https://github.com/dovecot/core/commit/1df777483912319a01110df6f8f48d1e84ff92ad
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/lib-storage/index/dbox-single/sdbox-storage.c
    M src/lib-storage/mail-storage-private.h
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: require MAIL_STORAGE_CLASS_FLAG_STUBS when caching

If we are going to be using the storage for caching, we should check that
the storage actually supports mail stubs.


  Commit: 1f2c35da2b96905bec6e45f88af0f33ee63789e6
      https://github.com/dovecot/core/commit/1f2c35da2b96905bec6e45f88af0f33ee63789e6
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M src/auth/auth-policy.c

  Log Message:
  -----------
  auth: Fix auth-policy crash when username is NULL

If SASL request is invalid, or incomplete, and username
is left NULL, handle it gracefully by adding just
NUL byte in auth policy digest for username.


Compare: https://github.com/dovecot/core/compare/c647daf549b9...1f2c35da2b96