[dovecot/core] c13fce: director: Code cleanup - move enum user_kill_state...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: c13fce16374a6fa8d127742c527498d38e777789
      https://github.com/dovecot/core/commit/c13fce16374a6fa8d127742c527498d38e777789
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c
    M src/director/director.h
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Code cleanup - move enum user_kill_state to director.h

This will be needed by following commits


  Commit: 79ee504bdf920f01e12e28f238799bf2616489df
      https://github.com/dovecot/core/commit/79ee504bdf920f01e12e28f238799bf2616489df
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director-request.c
    M src/director/director.c
    M src/director/doveadm-connection.c
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Code cleanup - added USER_IS_BEING_KILLED() macro


  Commit: 778a9861ee39eb23ec443a03cde832e3e31d7d37
      https://github.com/dovecot/core/commit/778a9861ee39eb23ec443a03cde832e3e31d7d37
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated


  Commit: 1b7cd57585d8c2f133dd612d2d5d9c775595659f
      https://github.com/dovecot/core/commit/1b7cd57585d8c2f133dd612d2d5d9c775595659f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director.c
    M src/director/director.h
    M src/director/test-user-directory.c
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Moved all user killing state to struct director_kill_context

This should make it a bit easier to understand the life time of user
killing. It also simplifies code by removing struct
director_user_kill_finish_ctx.

Finally, this already reduces memory usage with 32bit systems, and would
make it possible to reduce also on 64bit systems if timestamp is shrank to
31 bits and weak bit moved after it. I'm not sure if that would be better
for performance though. In any case it would provide free space for 4 extra
bytes if that were needed in future.


  Commit: 8cafec427a378daf68c253929232d498509d548c
      https://github.com/dovecot/core/commit/8cafec427a378daf68c253929232d498509d548c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.h
    M src/director/main.c

  Log Message:
  -----------
  director: Code cleanup - global director is no longer needed.


  Commit: 3404b66f3fda78955be9b6891ce5f5d6e13ef97a
      https://github.com/dovecot/core/commit/3404b66f3fda78955be9b6891ce5f5d6e13ef97a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Code cleanup - moved user kill startup to its own function.

No functional changes.


  Commit: aad23ef1531748997776e50a5272a2fc8e022f04
      https://github.com/dovecot/core/commit/aad23ef1531748997776e50a5272a2fc8e022f04
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: User move - Don't try to kick user's connections if user wasn't even known.


  Commit: b93ec4e5b569e1216d0c7a6f28cbdccfe4fb32ca
      https://github.com/dovecot/core/commit/b93ec4e5b569e1216d0c7a6f28cbdccfe4fb32ca
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c
    M src/director/director.h

  Log Message:
  -----------
  director: Send user's old and new backend IPs to flush script.

If user was created due to the user-move, don't execute the flush script
since it wouldn't really have any work to do anyway.


  Commit: faa01447c2f699b63ceccf129430a9ed46458083
      https://github.com/dovecot/core/commit/faa01447c2f699b63ceccf129430a9ed46458083
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/main.c

  Log Message:
  -----------
  director: Avoid assert-crash at deinit if user moves are still being added.

Fixes:
Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0)


  Commit: ec186c47c50bafcb66c5ac183b390c023cdf3fe5
      https://github.com/dovecot/core/commit/ec186c47c50bafcb66c5ac183b390c023cdf3fe5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-print-pager.c

  Log Message:
  -----------
  doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE


  Commit: a4a7440a1033203c48d5f0174b3d85514b79f3a0
      https://github.com/dovecot/core/commit/a4a7440a1033203c48d5f0174b3d85514b79f3a0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-master.c
    M src/doveadm/doveadm-print-pager.c
    M src/doveadm/doveadm-print.h

  Log Message:
  -----------
  doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro


  Commit: f65486adb62eb4c817cfad2deaf8befea3012787
      https://github.com/dovecot/core/commit/f65486adb62eb4c817cfad2deaf8befea3012787
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-fs.c

  Log Message:
  -----------
  doveadm fs get: Use pager formatter by default to avoid extra LF at the end.


Compare: https://github.com/dovecot/core/compare/b1d5d687ddc3...f65486adb62e