[dovecot/core] bd9848: director: Code cleanup - move enum user_kill_state...

Wed Oct 26 10:30:13 UTC 2016

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: bd984825690e1dd175494872287384bd5598423b
      https://github.com/dovecot/core/commit/bd984825690e1dd175494872287384bd5598423b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c
    M src/director/director.h
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Code cleanup - move enum user_kill_state to director.h

This will be needed by following commits

  Commit: 21f9786272b6f78a4a0ac72421349bcb7fd42fb4
      https://github.com/dovecot/core/commit/21f9786272b6f78a4a0ac72421349bcb7fd42fb4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director-request.c
    M src/director/director.c
    M src/director/doveadm-connection.c
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Code cleanup - added USER_IS_BEING_KILLED() macro

  Commit: 7d3ede1afd6ef96e71a5a120c08799d1e36be395
      https://github.com/dovecot/core/commit/7d3ede1afd6ef96e71a5a120c08799d1e36be395
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated

  Commit: 6f93a3dcb3c9bfe4145f376588e0e798a75f3527
      https://github.com/dovecot/core/commit/6f93a3dcb3c9bfe4145f376588e0e798a75f3527
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director-connection.c
    M src/director/director.c
    M src/director/director.h
    M src/director/test-user-directory.c
    M src/director/user-directory.c
    M src/director/user-directory.h

  Log Message:
  -----------
  director: Moved all user killing state to struct director_kill_context

This should make it a bit easier to understand the life time of user
killing. It also simplifies code by removing struct
director_user_kill_finish_ctx.

Finally, this already reduces memory usage with 32bit systems, and would
make it possible to reduce also on 64bit systems if timestamp is shrank to
31 bits and weak bit moved after it. I'm not sure if that would be better
for performance though. In any case it would provide free space for 4 extra
bytes if that were needed in future.

  Commit: 5c3b438e987bf52778ff21b2f1d1e515a1f080cf
      https://github.com/dovecot/core/commit/5c3b438e987bf52778ff21b2f1d1e515a1f080cf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.h
    M src/director/main.c

  Log Message:
  -----------
  director: Code cleanup - global director is no longer needed.

  Commit: 9309b3baafe62cd38698edea02fb11357005fde0
      https://github.com/dovecot/core/commit/9309b3baafe62cd38698edea02fb11357005fde0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: Code cleanup - moved user kill startup to its own function.

No functional changes.

  Commit: 06da11f17408f39294798d42766e091a881aa3f1
      https://github.com/dovecot/core/commit/06da11f17408f39294798d42766e091a881aa3f1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c

  Log Message:
  -----------
  director: User move - Don't try to kick user's connections if user wasn't even known.

  Commit: d0268f2a817fd57c2f6d927f8166f3f964a9cb25
      https://github.com/dovecot/core/commit/d0268f2a817fd57c2f6d927f8166f3f964a9cb25
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/director.c
    M src/director/director.h

  Log Message:
  -----------
  director: Send user's old and new backend IPs to flush script.

If user was created due to the user-move, don't execute the flush script
since it wouldn't really have any work to do anyway.

  Commit: 00e99bcbf9c9adb6b28a4aafac88cb7aba98ce41
      https://github.com/dovecot/core/commit/00e99bcbf9c9adb6b28a4aafac88cb7aba98ce41
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/director/main.c

  Log Message:
  -----------
  director: Avoid assert-crash at deinit if user moves are still being added.

Fixes:
Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0)

  Commit: 9c12525ea807c5e300ad1da91ec0286937cc00ec
      https://github.com/dovecot/core/commit/9c12525ea807c5e300ad1da91ec0286937cc00ec
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-print-pager.c

  Log Message:
  -----------
  doveadm: \f\n only between pages in pager

No more \f\n in the end.

  Commit: 98193d1a9235256c02777b5b17a1d1f77823e4b3
      https://github.com/dovecot/core/commit/98193d1a9235256c02777b5b17a1d1f77823e4b3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-print-pager.c

  Log Message:
  -----------
  doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE

  Commit: 9dc970171d487e3a8241e2af4b773c50e67020f5
      https://github.com/dovecot/core/commit/9dc970171d487e3a8241e2af4b773c50e67020f5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-master.c
    M src/doveadm/doveadm-print-pager.c
    M src/doveadm/doveadm-print.h

  Log Message:
  -----------
  doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro

  Commit: 2cc140b663e23ccc8b89b406851f176ee77ff931
      https://github.com/dovecot/core/commit/2cc140b663e23ccc8b89b406851f176ee77ff931
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-10-26 (Wed, 26 Oct 2016)

  Changed paths:
    M src/doveadm/doveadm-fs.c

  Log Message:
  -----------
  doveadm fs get: Use pager formatter by default to avoid extra LF at the end.

Compare: https://github.com/dovecot/core/compare/ccb431749072...2cc140b663e2