[dovecot/core] d90a92: global: timeout_remove(NULL) is a no-op

GitHub noreply at github.com
Wed Dec 13 13:00:11 EET 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: d90a924480a061683786e459a2e1c1d0b6e4f1e4
      https://github.com/dovecot/core/commit/d90a924480a061683786e459a2e1c1d0b6e4f1e4
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/dict/dict-connection.c
    M src/director/user-directory.c
    M src/imap/imap-notify.c
    M src/lib-http/http-client-host.c
    M src/lib-http/http-client-peer.c
    M src/lib-http/http-client-queue.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-ldap/ldap-connection.c
    M src/lib-master/anvil-client.c
    M src/lib-master/master-service.c
    M src/lib-sql/driver-pgsql.c
    M src/plugins/fts-lucene/lucene-wrapper.cc

  Log Message:
  -----------
  global: timeout_remove(NULL) is a no-op


  Commit: 4afd5b65670e52e1d513e707c96d626ab1856e03
      https://github.com/dovecot/core/commit/4afd5b65670e52e1d513e707c96d626ab1856e03
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/lib-ldap/ldap-connection.c
    M src/lib-master/master-service.c

  Log Message:
  -----------
  global: io_remove*(NULL) is a no-op


  Commit: c5e46dba179864f6f1adf196d46e7a0371b11914
      https://github.com/dovecot/core/commit/c5e46dba179864f6f1adf196d46e7a0371b11914
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/auth/auth-policy.c
    M src/doveadm/doveadm-cmd.c
    M src/lib-dcrypt/dcrypt-gnutls.c
    M src/lib-dcrypt/dcrypt-openssl.c
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/ostream-encrypt.c
    M src/lib-dict-backend/dict-ldap.c
    M src/lib-ldap/ldap-connection.c
    M src/lib-ldap/ldap-entry.c
    M src/lib-ldap/ldap-iterator.c
    M src/lib-ldap/ldap-search.c

  Log Message:
  -----------
  global: drop unnecessary parens in &(foo)

This makes the code more consistent since most of the repo uses the
no-parens style.  These inconsistencies were found using
`git grep '(&([^*]'` and any use of the parens in macros was ignored for
safety reasons.


  Commit: 0afd9a9acab584e770ffcd6a0e1e02e2d18d360a
      https://github.com/dovecot/core/commit/0afd9a9acab584e770ffcd6a0e1e02e2d18d360a
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/submission-login/client-authenticate.c
    M src/submission-login/client.c
    M src/submission-login/submission-proxy.c

  Log Message:
  -----------
  submission-login: remove unnecessary casts

Casting from a void * to any pointer type is automatic and doesn't
require an explicit cast.


  Commit: c4588e66e80482994cf0fbc45251cb8e9db6404d
      https://github.com/dovecot/core/commit/c4588e66e80482994cf0fbc45251cb8e9db6404d
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/submission-login/client-authenticate.c
    M src/submission-login/client.c
    M src/submission-login/submission-proxy.c

  Log Message:
  -----------
  submission-login: use container_of instead of casts


  Commit: 0cce67356125083a0affed3ca9cb4f278258e5be
      https://github.com/dovecot/core/commit/0cce67356125083a0affed3ca9cb4f278258e5be
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/submission/cmd-data.c
    M src/submission/cmd-helo.c
    M src/submission/cmd-mail.c
    M src/submission/cmd-noop.c
    M src/submission/cmd-quit.c
    M src/submission/cmd-rcpt.c
    M src/submission/cmd-rset.c
    M src/submission/cmd-vrfy.c
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission: remove unnecessary casts

Casting from a void * to any pointer type is automatic and doesn't
require an explicit cast.


Compare: https://github.com/dovecot/core/compare/47758f9335a0...0cce67356125


More information about the dovecot-cvs mailing list