[dovecot/pigeonhole] ca1773: global: start relying on io_remove{,_closed}(NULL)...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: ca1773cdd5d7f07543894b72003a1b652e025823
      https://github.com/dovecot/pigeonhole/commit/ca1773cdd5d7f07543894b72003a1b652e025823
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  global: start relying on io_remove{,_closed}(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove(&E);
	- }
	+ io_remove(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove_closed(&E);
	- }
	+ io_remove_closed(&E);


  Commit: 45cfd196caaae7fabcea476a9a965f691431c3c3
      https://github.com/dovecot/pigeonhole/commit/45cfd196caaae7fabcea476a9a965f691431c3c3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/managesieve-login/client.c
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  global: start relying on timeout_remove(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	timeout_remove(&E);
	- }
	+ timeout_remove(&E);


  Commit: dbc3f2f80b1a2528c58cd1aed9ad3b5776bfd764
      https://github.com/dovecot/pigeonhole/commit/dbc3f2f80b1a2528c58cd1aed9ad3b5776bfd764
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M src/lib-managesieve/managesieve-parser.c
    M src/lib-sieve-tool/mail-raw.c
    M src/lib-sieve/sieve-script.c
    M src/lib-sieve/storage/ldap/sieve-ldap-db.c
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  global: start relying on [io]_stream_unref(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	i_stream_unref(&E);
	- }
	+ i_stream_unref(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	o_stream_unref(&E);
	- }
	+ o_stream_unref(&E);


  Commit: 95a0c04ab3f540728a25f39a24e0376892ff6449
      https://github.com/dovecot/pigeonhole/commit/95a0c04ab3f540728a25f39a24e0376892ff6449
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M doc/example-config/conf.d/20-managesieve.conf

  Log Message:
  -----------
  doc: example-config: Document remaining supported managesieve_logout_format substitution variables.

A few were still omitted.


  Commit: fe3b7c4bff0907bc0fb1d5ab0251772e9978446a
      https://github.com/dovecot/pigeonhole/commit/fe3b7c4bff0907bc0fb1d5ab0251772e9978446a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-15 (Fri, 15 Dec 2017)

  Changed paths:
    M src/managesieve/managesieve-client.c

  Log Message:
  -----------
  managesieve: Include mail user variables in logout format

Also dropped the single-letter identifier for most fields to prevent conflicts with mail user variables; these were undocumented anyway.


Compare: https://github.com/dovecot/pigeonhole/compare/b5a9750a2212...fe3b7c4bff09