[dovecot/core] aa7058: lib-smtp: smtp_server_connection_pending_command_d...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: aa705831596732ffcca729b752451e24ee698e13
      https://github.com/dovecot/core/commit/aa705831596732ffcca729b752451e24ee698e13
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: smtp_server_connection_pending_command_data() - don't crash if smtp_parser is NULL


  Commit: a72c750649b9044b8d90e0f4f48a5c5af5c8954f
      https://github.com/dovecot/core/commit/a72c750649b9044b8d90e0f4f48a5c5af5c8954f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M src/submission/submission-commands.c

  Log Message:
  -----------
  lib-smtp: server: Fix panic when disconnecting client aborting commands

This happened at least if the relay server simply disconnected without
sending any output.

Fixes: Panic: file submission-commands.c: line 39: unreached


  Commit: 97fad7a944bf25f5a54512063d0827ef77eb1a14
      https://github.com/dovecot/core/commit/97fad7a944bf25f5a54512063d0827ef77eb1a14
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-18 (Mon, 18 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-command-parser.c

  Log Message:
  -----------
  lib-smtp: command parser: Fix error recovery.

Input characters were not skipped upon error, meaning that error recovery would encounter these again.
This would make the parser parse the same data over and over again, yielding the same error.
This in turn caused the SMTP server application to hang in an infinite input loop, submitting error replies in the process, thereby filling up the process memory until exhaustion.
Problem seen in submission service, but LMTP is also affected.


Compare: https://github.com/dovecot/core/compare/b1e79edd123d...97fad7a944bf