[dovecot/core] cfb605: lib-smtp: server: Fix compile error in smtp-server...

Fri Dec 22 13:30:22 EET 2017

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: cfb605f89247ce7e0144a1895fb23701536ca3c1
      https://github.com/dovecot/core/commit/cfb605f89247ce7e0144a1895fb23701536ca3c1
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-helo.c

  Log Message:
  -----------
  lib-smtp: server: Fix compile error in smtp-server-cmd-helo.c.

Error was:
"smtp-server-cmd-helo.c", line 140: void function cannot return value

  Commit: 28fede787bddc73f964134ff8871ac3094f3729f
      https://github.com/dovecot/core/commit/28fede787bddc73f964134ff8871ac3094f3729f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Fixed assertion in smtp_server_connection_next_reply() checking whether command is fully replied.

It did not handle LMTP DATA/BDAT command correctly, for which there can be multiple replies.

This fixes mixing local/remote recipients in LMTP, which used to crash:
Panic: file smtp-server-connection.c: line 610 (smtp_server_connection_next_reply): assertion failed: (cmd->state == SMTP_SERVER_COMMAND_STATE_READY_TO_REPLY && smtp_server_command_is_replied(cmd))

  Commit: 7923e2c54a080692d3a6e95db0069465c8a07824
      https://github.com/dovecot/core/commit/7923e2c54a080692d3a6e95db0069465c8a07824
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M doc/man/doveadm-acl.1.in
    M doc/man/doveadm-altmove.1.in
    M doc/man/doveadm-auth.1.in
    M doc/man/doveadm-batch.1.in
    M doc/man/doveadm-deduplicate.1.in
    M doc/man/doveadm-director.1.in
    M doc/man/doveadm-dump.1.in
    M doc/man/doveadm-exec.1.in
    M doc/man/doveadm-expunge.1.in
    M doc/man/doveadm-fetch.1.in
    M doc/man/doveadm-flags.1.in
    M doc/man/doveadm-force-resync.1.in
    M doc/man/doveadm-fs.1.in
    M doc/man/doveadm-fts.1.in
    M doc/man/doveadm-help.1.in
    M doc/man/doveadm-import.1.in
    M doc/man/doveadm-index.1.in
    M doc/man/doveadm-instance.1.in
    M doc/man/doveadm-kick.1.in
    M doc/man/doveadm-log.1.in
    M doc/man/doveadm-mailbox-cryptokey.1.in
    M doc/man/doveadm-mailbox.1.in
    M doc/man/doveadm-move.1.in
    M doc/man/doveadm-penalty.1.in
    M doc/man/doveadm-proxy.1.in
    M doc/man/doveadm-purge.1.in
    M doc/man/doveadm-pw.1.in
    M doc/man/doveadm-quota.1.in
    M doc/man/doveadm-replicator.1.in
    M doc/man/doveadm-save.1.in
    M doc/man/doveadm-search-query.7
    M doc/man/doveadm-search.1.in
    M doc/man/doveadm-stats.1.in
    M doc/man/doveadm-sync.1.in
    M doc/man/doveadm-user.1.in
    M doc/man/doveadm-who.1.in
    M doc/man/doveadm.1.in
    M doc/man/doveconf.1.in
    M doc/man/dovecot-lda.1.in
    M doc/man/dovecot.1.in

  Log Message:
  -----------
  man: Update version number to v2.3

  Commit: 6438494e2a2aea2c2e8557e50814a52853a4d499
      https://github.com/dovecot/core/commit/6438494e2a2aea2c2e8557e50814a52853a4d499
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-starttls.c
    M src/lib-smtp/smtp-server.h
    M src/submission-login/client.c

  Log Message:
  -----------
  lib-smtp: server: Change conn_start_tls() connection callback to return a success status.

  Commit: 7237272b0222ab4b02bca32b55b4fac4963b5c88
      https://github.com/dovecot/core/commit/7237272b0222ab4b02bca32b55b4fac4963b5c88
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add smtp_server_connection_set_ssl_streams().

It wraps smtp_server_connection_set_streams() and additionally marks the connection as SSL-secured.

  Commit: 70b97d678e6658a217e619f82b0248f60235c7fc
      https://github.com/dovecot/core/commit/70b97d678e6658a217e619f82b0248f60235c7fc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-starttls.c

  Log Message:
  -----------
  lib-smtp: server: STARTTLS command: Call smtp_server_connection_set_ssl_streams() after calling the conn_start_tls() connection callback.

This is called instead smtp_server_connection_set_streams(), so that the connection is now marked as SSL-secured.
This fixes a submission-login bug that prevented client login when ssl=required.

  Commit: 23ff476d9fa3186b98d01018bb7ec53ce880e932
      https://github.com/dovecot/core/commit/23ff476d9fa3186b98d01018bb7ec53ce880e932
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/want_sodium.m4
    M src/auth/Makefile.am

  Log Message:
  -----------
  auth: Don't include LIBSODIUM_LIBS in dependencies

Put it into AUTH_LIBS among other libraries that are used by auth.

  Commit: 8fe339187e3952db5a4ae4622c409a9287de394c
      https://github.com/dovecot/core/commit/8fe339187e3952db5a4ae4622c409a9287de394c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/doveadm/client-connection-tcp.c

  Log Message:
  -----------
  doveadm-server: Fix potential hangs with SSL connections

  Commit: 20b273fb581e1c82d3de8feb632ab92531b597bc
      https://github.com/dovecot/core/commit/20b273fb581e1c82d3de8feb632ab92531b597bc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M doc/example-config/conf.d/15-lda.conf

  Log Message:
  -----------
  example-config: Fix postmaster_address comment

The default value was wrong.

  Commit: 88a30153625f27d434e44b09c072219c3b0a737c
      https://github.com/dovecot/core/commit/88a30153625f27d434e44b09c072219c3b0a737c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/cc_fortify.m4

  Log Message:
  -----------
  m4: Avoid _FORTIFY_SOURCE redefinition warnings

Some source based distros like Gentoo already enable -D_FORTIFY_SOURCE=2
by default resulting in the following warnings during build:

<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

Patch by Eray Aslan

  Commit: 73c823e0c791f3c437eaa41ced78fe8e590a00f0
      https://github.com/dovecot/core/commit/73c823e0c791f3c437eaa41ced78fe8e590a00f0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M m4/want_sodium.m4

  Log Message:
  -----------
  m4: Fix detecting libsodium to use LIBS instead of LDFLAGS

Patch by Eray Aslan

  Commit: c0e0c976922fb59402778be7e2f2e28ba907d848
      https://github.com/dovecot/core/commit/c0e0c976922fb59402778be7e2f2e28ba907d848
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M src/plugins/imap-old-stats/imap-stats-plugin.c
    M src/plugins/imap-old-stats/imap-stats-plugin.h

  Log Message:
  -----------
  imap-old-stats plugin: Finish renaming the plugin

The init functions and dependency were named wrong, so it didn't work.

Compare: https://github.com/dovecot/core/compare/97fad7a944bf...c0e0c976922f