[dovecot/core] a731e3: submission: Initialize proxy connection before sta...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: a731e3b18f93735c222460e44692ca0bfac91688
      https://github.com/dovecot/core/commit/a731e3b18f93735c222460e44692ca0bfac91688
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/submission/submission-client.c

  Log Message:
  -----------
  submission: Initialize proxy connection before starting the SMTP server connection.

The smtp_server_connection_login() function gets pre-login connection data from login service, which can contain commands.
The execution of commands expects the proxy connection object to be initialized.


  Commit: 922a260e6b45f085a01da1edf770c101525a3115
      https://github.com/dovecot/core/commit/922a260e6b45f085a01da1edf770c101525a3115
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/submission-login/client-authenticate.c

  Log Message:
  -----------
  submission-login: Fix pipelining of commands beyond AUTH.

The master_data_prefix was initialized wrong; it omitted the expected '\0' byte after the helo field.


  Commit: aa8e45365fc9453397ef6b1c31ee75b90f62e596
      https://github.com/dovecot/core/commit/aa8e45365fc9453397ef6b1c31ee75b90f62e596
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/submission/submission-client.h

  Log Message:
  -----------
  submission: Dropped unused field from struct client.


  Commit: 961a5c472495203d4714a059a192fb0bf72d56d5
      https://github.com/dovecot/core/commit/961a5c472495203d4714a059a192fb0bf72d56d5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-24 (Sun, 24 Dec 2017)

  Changed paths:
    M src/submission/cmd-quit.c
    M src/submission/submission-client.c
    M src/submission/submission-client.h
    M src/submission/submission-common.h

  Log Message:
  -----------
  submission: Restructure handling of QUIT command.

- Avoid explicitly proxying QUIT command when the proxy connection is not ready: in that case the SMTP client connection will just send QUIT if appropriate, without waiting for reply.
- Add timeout for proxied QUIT command, so that there are no problems when the relay server hangs after QUIT (addresses FIXME).


Compare: https://github.com/dovecot/core/compare/3da7cb6c60e6...961a5c472495