[dovecot/core] 794501: lib-http: client: Keep connection reference throug...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 79450122997042f3c72a07c0b2153cc2b1f13c1d
      https://github.com/dovecot/core/commit/79450122997042f3c72a07c0b2153cc2b1f13c1d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-01-19 (Thu, 19 Jan 2017)

  Changed paths:
    M src/lib-http/http-client-connection.c

  Log Message:
  -----------
  lib-http: client: Keep connection reference throughout http_client_connection_return_response().

Before, it was held in two intervals.
Next commit requires this change, but it also simplifies this function significantly.


  Commit: 9465a050729f555318cbda2c5b9d531b04dbce7f
      https://github.com/dovecot/core/commit/9465a050729f555318cbda2c5b9d531b04dbce7f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-01-19 (Thu, 19 Jan 2017)

  Changed paths:
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: client: Make sure req->conn is only not NULL when that connection holds a reference to that request.

This consolidates the management of req->conn to one place, thereby preventing mishaps.
It makes sure req->conn is always properly assigned, making it more reliable.
This fixes a problem that emerged in the http-proxy.


Compare: https://github.com/dovecot/core/compare/c8ce80f4dd6b...9465a050729f