[dovecot/core] a44e36: login-common: Remove unnecessary client_ref/unref ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: a44e36b9c7fc0ad7dca26793c8216b13fb8632dd
      https://github.com/dovecot/core/commit/a44e36b9c7fc0ad7dca26793c8216b13fb8632dd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M src/login-common/client-common.c

  Log Message:
  -----------
  login-common: Remove unnecessary client_ref/unref from STARTTLS handling

There used to be code between them that could have destroyed the connection,
but that was removed long time ago.


  Commit: 5885eec2e3d74589c33aa5f59bf31e40df8ab583
      https://github.com/dovecot/core/commit/5885eec2e3d74589c33aa5f59bf31e40df8ab583
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M src/pop3-login/client.c

  Log Message:
  -----------
  pop3-login: Cleanup - uncork output unconditionally before client_unref()


  Commit: b833824981bc75af72adb844f8a4a992bd2f3ad3
      https://github.com/dovecot/core/commit/b833824981bc75af72adb844f8a4a992bd2f3ad3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-02 (Thu, 02 Nov 2017)

  Changed paths:
    M src/login-common/client-common.c

  Log Message:
  -----------
  login-common: client_unref() - always set client pointer to NULL

This is the common coding practise elsewhere as well.


Compare: https://github.com/dovecot/core/compare/1b7459fda7de...b833824981bc