[dovecot/core] de33a4: imapc: Fix leaking memory when sending imapc comma...

Wed Aug 22 13:00:16 EEST 2018

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: de33a4c9d44cee17e02f9c54367b3380a191ab85
      https://github.com/dovecot/core/commit/de33a4c9d44cee17e02f9c54367b3380a191ab85
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-storage.c
    M src/lib-storage/index/imapc/imapc-storage.h
    M src/plugins/quota/quota-imapc.c

  Log Message:
  -----------
  imapc: Fix leaking memory when sending imapc commands after authentication failure

  Commit: 06ce3261068c11879953ae1b37b34ebad0d330f0
      https://github.com/dovecot/core/commit/06ce3261068c11879953ae1b37b34ebad0d330f0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-smtp/smtp-command-parser.c

  Log Message:
  -----------
  lib-smtp: server: Fix memory leak when handling BDAT command

  Commit: e9e2cda1b8652aff63b4494d48f0d9c976e46f00
      https://github.com/dovecot/core/commit/e9e2cda1b8652aff63b4494d48f0d9c976e46f00
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/plugins/mail-crypt/doveadm-mail-crypt.c

  Log Message:
  -----------
  mail-crypt: Fix memory leak in "doveadm mailbox cryptokey generate"

  Commit: 9140a101998296ff7e941e812f61d1f0e70c21f5
      https://github.com/dovecot/core/commit/9140a101998296ff7e941e812f61d1f0e70c21f5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/istream-decrypt.h
    M src/plugins/mail-crypt/fs-crypt-common.c
    M src/plugins/mail-crypt/mail-crypt-plugin.c

  Log Message:
  -----------
  lib-dcrypt, mail-crypt: Fix leaking memory when using non-global keys

The users' private keys had one reference too much. Because of key cache,
most likely the keys were leaked only once at deinit.

Changed the i_stream_create_decrypt_callback() API so that it allows the
callback to create the key itself without having to store it anywhere.

In this case the key was already added to cache, which increased its
refcount. So an alternative fix would have been to simply unreferenced the
key before returning it. It's a bit ugly though to rely on such caches,
since without the cache the code would be buggy.

  Commit: 74c793987967ac419648bae3569d1f5507681638
      https://github.com/dovecot/core/commit/74c793987967ac419648bae3569d1f5507681638
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/plugins/mail-crypt/mail-crypt-acl-plugin.c

  Log Message:
  -----------
  mail-crypt-acl: Fix memory leak when updating ACLs

  Commit: beb958d4e1e50f1bf9c2a2780a17d44c5082164c
      https://github.com/dovecot/core/commit/beb958d4e1e50f1bf9c2a2780a17d44c5082164c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/plugins/virtual/virtual-config.c

  Log Message:
  -----------
  virtual: Fix memory leak when selecting mailboxes with '-' or /metadata

  Commit: d05d508f8e52b340ec01e472b72da600e881a62a
      https://github.com/dovecot/core/commit/d05d508f8e52b340ec01e472b72da600e881a62a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib/lib-event.c

  Log Message:
  -----------
  lib: Free global_event_stack array at deinit

  Commit: 733c581f5325c7a7df72c1640520efaa1a65e019
      https://github.com/dovecot/core/commit/733c581f5325c7a7df72c1640520efaa1a65e019
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib/lib.c
    M src/lib/restrict-access.c
    M src/lib/restrict-access.h

  Log Message:
  -----------
  lib: restrict-access: Free chroot_dir at deinit

  Commit: a6f1fe5748c4e16465f22c5f5eac7933777f8b11
      https://github.com/dovecot/core/commit/a6f1fe5748c4e16465f22c5f5eac7933777f8b11
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-master/master-service-private.h
    M src/lib-master/master-service.c

  Log Message:
  -----------
  lib-master: Allow calling master_service_deinit() without _init_finish()

  Commit: 2a43107d305776ed2478c57be5792798823ac268
      https://github.com/dovecot/core/commit/2a43107d305776ed2478c57be5792798823ac268
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/dsync/dsync-ibc-stream.c

  Log Message:
  -----------
  dsync: ibc - reference iostreams internally

This makes it clearer who needs to reference and unreference the streams.

  Commit: 843850634541c184a472cd866b522bd204f43493
      https://github.com/dovecot/core/commit/843850634541c184a472cd866b522bd204f43493
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/doveadm/doveadm-dsync.c

  Log Message:
  -----------
  dsync: Fix memory leak - unreference iostreams at deinit

Only some of the code paths need unreferencing, so also add a reference to
the other code paths.

  Commit: 266e4ec7465d4bd2336e9248f325932ccd6fe404
      https://github.com/dovecot/core/commit/266e4ec7465d4bd2336e9248f325932ccd6fe404
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/doveadm/doveadm-auth.c

  Log Message:
  -----------
  doveadm user: Fix memory leak

  Commit: 79031678fea4325a74ee7692e49612abf2318524
      https://github.com/dovecot/core/commit/79031678fea4325a74ee7692e49612abf2318524
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/doveadm/doveadm-log.c

  Log Message:
  -----------
  doveadm log find: Fix memory leak

  Commit: be4e0a59d31349d4a6ece3a556e60c7d7a25964c
      https://github.com/dovecot/core/commit/be4e0a59d31349d4a6ece3a556e60c7d7a25964c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/doveadm/doveadm-dump-index.c

  Log Message:
  -----------
  doveadm dump: Fix dumping "vsize" header in dovecot.index

It was trying to print it as the "vsize" header in dovecot.list.index.
This caused confusing output, as well as potentially accessing memory
out of bounds.

  Commit: c888490abe4eb4f518bd57b0ec9105b5b46b04da
      https://github.com/dovecot/core/commit/c888490abe4eb4f518bd57b0ec9105b5b46b04da
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib/lib-event.c

  Log Message:
  -----------
  lib: Fix memory leak at deinit if log_core_filter is set

  Commit: f39064b4ee28235c4e8407d2533b0fd99dac0813
      https://github.com/dovecot/core/commit/f39064b4ee28235c4e8407d2533b0fd99dac0813
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: Fix memory leak in mail_storage_set_internal_error()

  Commit: fd03ef3913fe211644ca8a2b87ba6c9bcde6303f
      https://github.com/dovecot/core/commit/fd03ef3913fe211644ca8a2b87ba6c9bcde6303f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Cleanup - reorder code

Makes the next commit cleaner.

  Commit: 505491dd961113f2a276c3e4ad9cb6aa9473c594
      https://github.com/dovecot/core/commit/505491dd961113f2a276c3e4ad9cb6aa9473c594
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Cleanup - move code to lda_deliver() function

No functional changes.

  Commit: af55d18cf61d97ba661233fd89aeca579a187572
      https://github.com/dovecot/core/commit/af55d18cf61d97ba661233fd89aeca579a187572
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Deinitialize cleanly if mail delivery fails

  Commit: 449826e05705747fb3468e9eac9f70d674b52711
      https://github.com/dovecot/core/commit/449826e05705747fb3468e9eac9f70d674b52711
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lda/main.c

  Log Message:
  -----------
  lda: Deinitialize cleanly if user doesn't exist in userdb

  Commit: 48b7e308c96173eee88dd335044aad3398bba87a
      https://github.com/dovecot/core/commit/48b7e308c96173eee88dd335044aad3398bba87a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-dict/dict-file.c

  Log Message:
  -----------
  dict-file: Fix memory leak when file is recreated during lock wait

  Commit: ade6a48883cc1f4070cc2bc8a1342197ab6a1eb4
      https://github.com/dovecot/core/commit/ade6a48883cc1f4070cc2bc8a1342197ab6a1eb4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-08-22 (Wed, 22 Aug 2018)

  Changed paths:
    M src/lib-dict/dict-file.c

  Log Message:
  -----------
  dict-file: If write failed, file was left locked

Compare: https://github.com/dovecot/core/compare/ba6572fb921b...ade6a48883cc
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.