[dovecot/pigeonhole] 3dce38: plugins: imap-filter-sieve: Fix segfault occurring...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 3dce3817347c01ee467b4dd393dee4553b84ac02
      https://github.com/dovecot/pigeonhole/commit/3dce3817347c01ee467b4dd393dee4553b84ac02
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/imap-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Fix segfault occurring in recently added debug message.

The debug message pertains to skipping secondary scripts that failed to
compile. This debug message will not actually be triggered in the current
implementation, but this will become problematic in the future.

Problem found by Coverity.


  Commit: 97cfb22eae5181ad91ae656c16f365d0b5f40977
      https://github.com/dovecot/pigeonhole/commit/97cfb22eae5181ad91ae656c16f365d0b5f40977
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M src/plugins/imap-filter-sieve/imap-filter-sieve.c

  Log Message:
  -----------
  plugins: imap-filter-sieve: Add assertion on attempting to execute at least one script.

Coverity complains about last_script possibly being empty in
imap_sieve_filter_run_scripts(), which is actually not possible, since the
function would not be called if there is no script to execute. Added assertion
to make that clear.


Compare: https://github.com/dovecot/pigeonhole/compare/41b9adcb2dea...97cfb22eae51
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.