[dovecot/core] 46105d: lib-index: Add mail_index_set_error_nolog()

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 46105d6267a407aecd336d5c8063f5e726ec628e
      https://github.com/dovecot/core/commit/46105d6267a407aecd336d5c8063f5e726ec628e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/lib-index/mail-index-private.h
    M src/lib-index/mail-index.c

  Log Message:
  -----------
  lib-index: Add mail_index_set_error_nolog()


  Commit: 8e4c41cde73bbb47a465d27625309e7c781f1daf
      https://github.com/dovecot/core/commit/8e4c41cde73bbb47a465d27625309e7c781f1daf
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/lib-storage/index/index-transaction.c

  Log Message:
  -----------
  lib-storage: Set index error on transaction commit() callback

The commit callback is setting errors to storage. However, it's being
called from mail_index_transaction_commit() whose callers are expecting
the error to be in index. If that index error was attempted to be used,
it could have been wrong or NULL. Fix this by setting the same storage
error also to the index.


  Commit: 5a69ecf5ac3ba46b05708083dde1c46eadc78f60
      https://github.com/dovecot/core/commit/5a69ecf5ac3ba46b05708083dde1c46eadc78f60
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/lib-storage/mail-storage.c

  Log Message:
  -----------
  lib-storage: mail_storage_set_index_error() - handle NULL index error

This avoids assert-crashing later on in mail*_get_last_internal_error().

This could potentially be an assert instead of setting it as "BUG", but
it looks like there are various code paths in lib-index that return -1
without setting an error. (That's to avoid duplicate error logging,
although it could now be fixed with mail_index_set_error_nolog().)


  Commit: fce72ce5a74ac0de641f1cb9b500c68203f33fba
      https://github.com/dovecot/core/commit/fce72ce5a74ac0de641f1cb9b500c68203f33fba
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/lib-http/Makefile.am

  Log Message:
  -----------
  lib-http: Only depend on iostream openssl lib if building with openssl

Fixes build without openssl


  Commit: 9e61bf46941c6615f34815a6c717aee717189e60
      https://github.com/dovecot/core/commit/9e61bf46941c6615f34815a6c717aee717189e60
  Author: Jarkko Mourujärvi <jarkko.mourujarvi at dovecot.fi>
  Date:   2018-01-15 (Mon, 15 Jan 2018)

  Changed paths:
    M src/config/doveconf.c

  Log Message:
  -----------
  doveconf: add hostname to output


Compare: https://github.com/dovecot/core/compare/8fe22c9108db...9e61bf46941c