[dovecot/pigeonhole] 523913: lib-sieve: store action: Sanitize both specified a...

[GitHub]

  Branch: refs/heads/master-0.4
  Home:   https://github.com/dovecot/pigeonhole
  Commit: 5239136db607898b23916fc936557499d2caa5b7
      https://github.com/dovecot/pigeonhole/commit/5239136db607898b23916fc936557499d2caa5b7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/lib-sieve/sieve-actions.c

  Log Message:
  -----------
  lib-sieve: store action: Sanitize both specified and virtual mailbox names in log strings.

Before, the virtual mailbox name was not sanitized, which caused control
characters to be displayed in log messages. Also, the mailbox name would be
mentioned twice in the log message, once santized and once unsanitized.


  Commit: 83155b61f9e071ddf39b52eb0e7dcd71ce506bb5
      https://github.com/dovecot/pigeonhole/commit/83155b61f9e071ddf39b52eb0e7dcd71ce506bb5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/lib-sieve-tool/Makefile.am
    R src/lib-sieve-tool/mail-raw.c
    R src/lib-sieve-tool/mail-raw.h
    M src/lib-sieve/util/Makefile.am
    A src/lib-sieve/util/mail-raw.c
    A src/lib-sieve/util/mail-raw.h
    M src/testsuite/Makefile.am

  Log Message:
  -----------
  Move mail-raw from lib-sieve-tool to lib-sieve/util.

Needed for use in test suite.


  Commit: f3a9fe01559135c3b6fa34c30d48a2f66673e703
      https://github.com/dovecot/pigeonhole/commit/f3a9fe01559135c3b6fa34c30d48a2f66673e703
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/lib-sieve/util/mail-raw.c
    M src/lib-sieve/util/mail-raw.h

  Log Message:
  -----------
  lib-sieve: util: mail-raw: Implemented mail_raw_open_stream().

This allows using a seekable stream as mail directly.


  Commit: 8e6bc742715c2ea840c8fc3899bf4fef02dd8cde
      https://github.com/dovecot/pigeonhole/commit/8e6bc742715c2ea840c8fc3899bf4fef02dd8cde
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-mail: istream: Remove useless check.

This is tested already in the assertion that precedes it.


  Commit: 14ec6fe861403aa09a3b5790d113247fc1e1f94d
      https://github.com/dovecot/pigeonhole/commit/14ec6fe861403aa09a3b5790d113247fc1e1f94d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M src/lib-sieve/util/edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: edit-mail: istream: Fix bug in calculation of stream position.

This caused an assert panic when the application or child stream did not skip
all buffered data immediately. This was reproducible only when the message input
stream consisted of a concatenation of smaller streams, which is used in LMTP to
prepend a few headers.

The panic was:

Panic: file istream.c: line 329 (i_stream_read_memarea): assertion failed: ((size_t)ret+old_size == _stream->pos - _stream->skip)


  Commit: b1773c10dbf5806b2ef2ec669f4da8cbf6a8d7a3
      https://github.com/dovecot/pigeonhole/commit/b1773c10dbf5806b2ef2ec669f4da8cbf6a8d7a3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-sieve/util/Makefile.am
    A src/lib-sieve/util/test-edit-mail.c

  Log Message:
  -----------
  lib-sieve: util: Created basic test suite for edit-mail.

Previously, this was only tested implicitly in the Sieve test suite. Now, it is
tested explicitly, which allows for more flexibility in the testing scenario.

It now extensively tests one scenario that used to fail.


  Commit: e66563f059be1a7f974612bc62057ac1594e70fb
      https://github.com/dovecot/pigeonhole/commit/e66563f059be1a7f974612bc62057ac1594e70fb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-sieve/sieve-validator.c

  Log Message:
  -----------
  lib-sieve: Fix assert panic occurring when used command has external tag, but is not registered.

This occurred for example when the "fileinto" command is used with only the
"copy" extension in the require line.

Panic message was:

Panic: file hash.c: line 263 (hash_table_insert_node): assertion failed: (opcode == HASH_TABLE_OP_UPDATE)


Compare: https://github.com/dovecot/pigeonhole/compare/16d7faebd8a5...e66563f059be