[dovecot/core] 238899: lib-mail: rfc822-parser - Add asserts to make sure...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 238899c225612d1bda1cb1a93437a23e287b098c
      https://github.com/dovecot/core/commit/238899c225612d1bda1cb1a93437a23e287b098c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/rfc822-parser.c

  Log Message:
  -----------
  lib-mail: rfc822-parser - Add asserts to make sure parser state is correct


  Commit: 260c2d9e6c8eb66fd78d9f68376777efc068dcc0
      https://github.com/dovecot/core/commit/260c2d9e6c8eb66fd78d9f68376777efc068dcc0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: test-message-address - Add TEST_MESSAGE_ADDRESS_FLAG_SKIP_LIST flag

This commit just adds the flag and sets it to 0 for all existing tests.


  Commit: d949689911a2321cd711c70665f3f11dcafbbbd3
      https://github.com/dovecot/core/commit/d949689911a2321cd711c70665f3f11dcafbbbd3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: Fix out-of-bounds read when parsing an invalid email address

The included unit test doesn't fail, but running it with valgrind shows
"Invalid read of size 1" error.

Broken in d6737a17a27402e7a262f7ba8a2ed588d576f23c

Discovered by Aleksandar Nikolic of Cisco Talos


  Commit: 1b93f7362b2847a3430717cce0725611fac57d4e
      https://github.com/dovecot/core/commit/1b93f7362b2847a3430717cce0725611fac57d4e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/message-date.c
    M src/lib-mail/message-part-data.c
    M src/lib-mail/rfc2231-parser.c
    M src/lib-mail/rfc822-parser.c

  Log Message:
  -----------
  lib-mail: Make sure parsers don't accidentally go much beyond end pointer


  Commit: 57f850f7af444094a4ce574423d9f3da0a49b785
      https://github.com/dovecot/core/commit/57f850f7af444094a4ce574423d9f3da0a49b785
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/rfc822-parser.h

  Log Message:
  -----------
  lib-mail: Add rfc822_parser_deinit()

It's not a strict requirement to call this, but it assert-crashes if the
state isn't valid.


  Commit: 6f685c30a4db4c62008a509adb758b1d85fa149d
      https://github.com/dovecot/core/commit/6f685c30a4db4c62008a509adb758b1d85fa149d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/message-id.c
    M src/lib-mail/message-parser.c

  Log Message:
  -----------
  lib-mail: Refactor code to make the next commit smaller


  Commit: d603818f755c9095b1bfb0e0ec99641f6b0b4bc5
      https://github.com/dovecot/core/commit/d603818f755c9095b1bfb0e0ec99641f6b0b4bc5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M src/lib-mail/istream-attachment-extractor.c
    M src/lib-mail/message-address.c
    M src/lib-mail/message-date.c
    M src/lib-mail/message-decoder.c
    M src/lib-mail/message-id.c
    M src/lib-mail/message-parser.c
    M src/lib-mail/message-part-data.c
    M src/lib-mail/message-search.c
    M src/lib-mail/test-rfc2231-parser.c
    M src/lib-mail/test-rfc822-parser.c
    M src/plugins/fts/fts-build-mail.c
    M src/plugins/fts/fts-parser-script.c

  Log Message:
  -----------
  global: Call rfc822_parser_deinit() wherever possible


Compare: https://github.com/dovecot/core/compare/dc0e67831439...d603818f755c