[dovecot/core] a7e32b: lib: str_free(NULL) should be a no-op

GitHub noreply at github.com
Mon Mar 12 12:00:37 EET 2018


  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: a7e32badbc7064b62a2b5b4b12c0ef02e568a6f4
      https://github.com/dovecot/core/commit/a7e32badbc7064b62a2b5b4b12c0ef02e568a6f4
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib/str.c

  Log Message:
  -----------
  lib: str_free(NULL) should be a no-op


  Commit: e741abe858d91892415833da1ee9c64388097fdc
      https://github.com/dovecot/core/commit/e741abe858d91892415833da1ee9c64388097fdc
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/imap/imap-fetch.c
    M src/lib-fs/fs-metawrap.c
    M src/lib-fts/fts-filter.c
    M src/lib-http/http-client-request.c
    M src/lib-storage/index/cydir/cydir-sync.c
    M src/lib-storage/index/index-search-mime.c
    M src/lib/istream.c
    M src/login-common/client-common.c
    M src/plugins/acl/acl-attributes.c
    M src/plugins/fts-solr/fts-backend-solr.c

  Log Message:
  -----------
  global: start relying on str_free(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	str_free(&E);
	- }
	+ str_free(&E);


  Commit: 431971ab7f1823d6212d545cba0a3ec00ae7d43d
      https://github.com/dovecot/core/commit/431971ab7f1823d6212d545cba0a3ec00ae7d43d
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib/iostream-proxy.c

  Log Message:
  -----------
  lib: iostream_proxy_unref(NULL) should be a no-op


  Commit: 90c587569d7d807ae26e080d6950de956767ed0d
      https://github.com/dovecot/core/commit/90c587569d7d807ae26e080d6950de956767ed0d
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/login-common/client-common.c
    M src/login-common/login-proxy.c

  Log Message:
  -----------
  global: start relying on iostream_proxy_unref(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	iostream_proxy_unref(&E);
	- }
	+ iostream_proxy_unref(&E);


  Commit: ba110cd15ce4f9115d80dc8b2557ff2225cb741b
      https://github.com/dovecot/core/commit/ba110cd15ce4f9115d80dc8b2557ff2225cb741b
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-ssl-iostream/iostream-ssl.c

  Log Message:
  -----------
  ssl-iostream: ssl_iostream_destroy(NULL) should be a no-op


  Commit: f5ab340f182b6a64830f03fb849ca7cdc8c0404c
      https://github.com/dovecot/core/commit/f5ab340f182b6a64830f03fb849ca7cdc8c0404c
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/doveadm/client-connection-tcp.c
    M src/doveadm/doveadm-dsync.c
    M src/lib-smtp/smtp-server-connection.c
    M src/login-common/client-common.c
    M src/login-common/login-proxy.c

  Log Message:
  -----------
  global: start relying on ssl_iostream_destroy(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	ssl_iostream_destroy(&E);
	- }
	+ ssl_iostream_destroy(&E);


  Commit: 9c22e26cf5ce7fcbda4307f067fdfcef445aff34
      https://github.com/dovecot/core/commit/9c22e26cf5ce7fcbda4307f067fdfcef445aff34
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-mail/mail-html2text.c

  Log Message:
  -----------
  lib-mail: mail_html2text_deinit(NULL) should be a no-op


  Commit: 27aed64c71c1fd94ef5ff9f0654698f84839af67
      https://github.com/dovecot/core/commit/27aed64c71c1fd94ef5ff9f0654698f84839af67
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-mail/message-snippet.c

  Log Message:
  -----------
  lib-mail: start relying on mail_html2text_deinit(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	-       mail_html2text_deinit(&E);
	- }
	+ mail_html2text_deinit(&E);


  Commit: 4db31f1f405977ef53fdd61ea980fff2cb551938
      https://github.com/dovecot/core/commit/4db31f1f405977ef53fdd61ea980fff2cb551938
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-storage/mailbox-header.c

  Log Message:
  -----------
  lib-storage: mailbox_header_lookup_unref(NULL) should be a no-op


  Commit: e1d3ec5f95933186e65cb9441a914dffc196005c
      https://github.com/dovecot/core/commit/e1d3ec5f95933186e65cb9441a914dffc196005c
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/doveadm/doveadm-mail-iter.c
    M src/doveadm/dsync/dsync-mailbox-export.c
    M src/imap/imap-fetch.c
    M src/lib-imap-storage/imap-msgpart.c
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/index-search.c
    M src/plugins/mail-log/mail-log-plugin.c
    M src/plugins/virtual/virtual-mail.c

  Log Message:
  -----------
  global: start relying on mailbox_header_lookup_unref(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	-       mailbox_header_lookup_unref(&E);
	- }
	+ mailbox_header_lookup_unref(&E);


  Commit: 8c6e305ad18eb2213b3083833d6e7456625ca0bb
      https://github.com/dovecot/core/commit/8c6e305ad18eb2213b3083833d6e7456625ca0bb
  Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-index/mail-cache.c
    M src/lib-storage/index/index-mailbox-size.c
    M src/lib-storage/mail-autoexpunge.c
    M src/lib/file-lock.c
    M src/plugins/fts-squat/squat-trie.c
    M src/plugins/fts-squat/squat-uidlist.c

  Log Message:
  -----------
  global: start relying on file_lock_free(NULL) being a no-op

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	-       file_lock_free(&E);
	- }
	+ file_lock_free(&E);


  Commit: 5d3a81e1bf4031d1ab7945d60eb2f9bbd9cf47f1
      https://github.com/dovecot/core/commit/5d3a81e1bf4031d1ab7945d60eb2f9bbd9cf47f1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-storage/index/index-mail.c

  Log Message:
  -----------
  lib-storage: Code cleanup - remove unnecessary temporary variable


  Commit: 59eb3b664091003bd8c7b627bc7fef73cde832e1
      https://github.com/dovecot/core/commit/59eb3b664091003bd8c7b627bc7fef73cde832e1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M src/lib-storage/index/index-mail.c

  Log Message:
  -----------
  lib-storage: Fix memory leak when search accessed headers but found no mails

For example fetching headers with UID FETCH for a nonexistent UID.


Compare: https://github.com/dovecot/core/compare/f904b00fb68f...59eb3b664091


More information about the dovecot-cvs mailing list