[dovecot/core] 435e4f: lib-mail: message-address: Add support for parsing...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 435e4ffe5ac87cdf07a7c8be9289a25f8334ff6e
      https://github.com/dovecot/core/commit/435e4ffe5ac87cdf07a7c8be9289a25f8334ff6e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-mail/message-address.c
    M src/lib-mail/message-address.h
    M src/lib-mail/test-message-address.c

  Log Message:
  -----------
  lib-mail: message-address: Add support for parsing RFC5322 "path" syntax.

This is either a single angle-addr or just <>. This path syntax differs from the
RFC5321 "Path" syntax in that it allows whitespace, which is very important when
it is parsed from a header.


  Commit: 61f64974623494e8c8a87d943cc8e551b28501db
      https://github.com/dovecot/core/commit/61f64974623494e8c8a87d943cc8e551b28501db
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-lda/mail-deliver.c

  Log Message:
  -----------
  lib-lda: Parse Return-Path header using RFC5322 (IMF) "path" syntax, rather than RFC5321 (SMTP) "Path" syntax.

SMTP does not allow white space, which causes all kinds of trouble when the
address is parsed from a header field.


  Commit: 0f9b9561c73aca7879f1dd6c106ec82a034428e5
      https://github.com/dovecot/core/commit/0f9b9561c73aca7879f1dd6c106ec82a034428e5
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rcpt.c

  Log Message:
  -----------
  lib-smtp: server: Fix double decrement of RCPT pending counter upon error.

The pending counter was sometimes decremented twice in specific error
conditions, leading to an assert panic in the DATA command. This was caused by
some dead code. If the MAIL command failed in a pipeline before the RCPT command,
the assert was triggered.

Panic was:

Panic: file smtp-server-cmd-data.c: line 354 (cmd_data_start): assertion failed: (conn->state.pending_mail_cmds == 0 && conn->state.pending_rcpt_cmds == 0)


  Commit: f0908f013dbf53ae5ee0ab546eeebf7d85c0d256
      https://github.com/dovecot/core/commit/f0908f013dbf53ae5ee0ab546eeebf7d85c0d256
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-mail.c

  Log Message:
  -----------
  lib-smtp: server: MAIL command: Make sure conn->state.pending_mail_cmds cannot decrement through zero.

Added assertion.


  Commit: ab4b3fd0001930742c7626278bca8c5612c10a4f
      https://github.com/dovecot/core/commit/ab4b3fd0001930742c7626278bca8c5612c10a4f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rcpt.c

  Log Message:
  -----------
  lib-smtp: server: RCPT command: Make sure conn->state.pending_rcpt_cmds cannot decrement through zero.

Added assertion.


Compare: https://github.com/dovecot/core/compare/db0373bfbfa3...ab4b3fd00019