[dovecot/core] 6e1e25: lib-auth: Prevent double-disconnect

GitHub noreply at github.com
Tue Mar 13 09:30:35 EET 2018


  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 6e1e25eb9b30e472ffb72340b440bb610eafbcea
      https://github.com/dovecot/core/commit/6e1e25eb9b30e472ffb72340b440bb610eafbcea
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-auth/auth-server-connection.c
    M src/lib-auth/auth-server-connection.h

  Log Message:
  -----------
  lib-auth: Prevent double-disconnect

When disconnecting, it's possible that
disconnect gets called twice by some callback,
so protect it with a boolean.

Fixes Panic: file hash.c: line 152 (hash_table_clear): assertion failed: (table->frozen == 0)


  Commit: 5403eb2c169ef87d6cc6f7ecbf453f2a012fb900
      https://github.com/dovecot/core/commit/5403eb2c169ef87d6cc6f7ecbf453f2a012fb900
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/lib-auth/auth-server-connection.c
    M src/lib-auth/auth-server-connection.h

  Log Message:
  -----------
  lib-auth: Require being connected before adding requests


  Commit: cca32a311aff39d37c7d579a1c55f3702a87ab36
      https://github.com/dovecot/core/commit/cca32a311aff39d37c7d579a1c55f3702a87ab36
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/auth/db-lua.c

  Log Message:
  -----------
  auth: db-lua - Use luaL_error correctly


  Commit: 976105f17e11448476cc438e299151eb31fd15ae
      https://github.com/dovecot/core/commit/976105f17e11448476cc438e299151eb31fd15ae
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2018-03-13 (Tue, 13 Mar 2018)

  Changed paths:
    M src/auth/db-lua.c

  Log Message:
  -----------
  auth: db-lua - Do not assert-crash if given parameter was not auth_request

Use luaL_error instead that will back out more gracefully.

Fixes Panic: file db-lua.c: line 279 (auth_lua_check_auth_request): assertion failed: (lua_istable(script->L, arg))


Compare: https://github.com/dovecot/core/compare/c3df1c9efed5...976105f17e11


More information about the dovecot-cvs mailing list