[dovecot/core | refs/heads/master] c5a99e78: global: Use array_last instead of array_idx

noreply at dovecot.org noreply at dovecot.org
Thu Jan 10 11:00:07 EET 2019


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: c5a99e78b625dfac18dc6d88642ca6d23bb438c3
      https://github.com/dovecot/core/commit/c5a99e78b625dfac18dc6d88642ca6d23bb438c3
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/lib-imap/imap-parser.c
    M src/lib-mail/test-istream-attachment.c
    M src/lib-storage/index/dbox-multi/mdbox-save.c
    M src/lib-storage/index/dbox-single/sdbox-save.c
    M src/lib-storage/index/index-search-mime.c
    M src/lib-storage/mail-storage-hooks.c

  Log Message:
  -----------
  global: Use array_last instead of array_idx

@@
expression E;
@@

-array_idx(E, array_count(E) - 1)
+array_last(E)

@@
expression E;
@@

-array_idx_modifiable(E, array_count(E) - 1)
+array_last_modifiable(E)

  Commit: 48c70592eb36b1263ad63e3c1dca8a0b5aff09ba
      https://github.com/dovecot/core/commit/48c70592eb36b1263ad63e3c1dca8a0b5aff09ba
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/doveadm/doveadm-cmd.c
    M src/imap/imap-fetch.c
    M src/lib-fts/fts-filter-normalizer-icu.c
    M src/lib-imap/imap-parser.c
    M src/lib-index/mail-index-strmap.c
    M src/lib-index/mail-index.c
    M src/lib-storage/index/dbox-multi/mdbox-save.c
    M src/lib-storage/index/dbox-single/sdbox-save.c
    M src/lib-storage/index/index-attachment.c
    M src/lib-storage/index/index-search-mime.c
    M src/plugins/virtual/virtual-storage.c

  Log Message:
  -----------
  global: Use array_pop_back

@@
expression A;
@@

-array_delete(A, array_count(A)-1, 1)
+array_pop_back(A)

And manually fixing the few missed ones

  Commit: 9b726934956ed9ca02077a82f7b2a1d74b7c9146
      https://github.com/dovecot/core/commit/9b726934956ed9ca02077a82f7b2a1d74b7c9146
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/doveadm/doveadm-mail-server.c
    M src/doveadm/dsync/dsync-ibc-pipe.c
    M src/lib-dict/dict-memcached-ascii.c
    M src/lib-dict/dict-redis.c
    M src/lib-http/http-client-connection.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/test-imapc-client.c
    M src/lib-smtp/smtp-client-command.c
    M src/lib-sql/driver-test.c
    M src/lib-storage/index/pop3c/pop3c-client.c
    M src/plugins/quota/quota-imapc.c

  Log Message:
  -----------
  global: Use array_pop_front

@@
expression A;
@@

-array_delete(A, 0, 1)
+array_pop_front(A)

  Commit: 70540d8b3e0799113fa4c47e3b778efb4679f24f
      https://github.com/dovecot/core/commit/70540d8b3e0799113fa4c47e3b778efb4679f24f
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c
    M src/lib/var-expand.c

  Log Message:
  -----------
  global: Use array_push_front

@@
expression A,I;
@@

-array_insert(A, 0, I, 1)
+array_push_front(A, I)

  Commit: fc1964ab66639e85e74d0883b898f50f5126309a
      https://github.com/dovecot/core/commit/fc1964ab66639e85e74d0883b898f50f5126309a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/auth/auth-worker-server.c
    M src/auth/auth.c
    M src/auth/db-dict.c
    M src/auth/db-ldap.c
    M src/auth/db-lua.c
    M src/auth/passdb-template.c
    M src/auth/passdb.c
    M src/auth/userdb-template.c
    M src/auth/userdb.c
    M src/config/config-parser.c
    M src/config/doveconf.c
    M src/dict/dict-commands.c
    M src/director/director-connection.c
    M src/director/director-host.c
    M src/director/director-request.c
    M src/director/director-test.c
    M src/director/mail-host.c
    M src/director/user-directory.c
    M src/doveadm/client-connection-http.c
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-dump.c
    M src/doveadm/doveadm-kick.c
    M src/doveadm/doveadm-mail-batch.c
    M src/doveadm/doveadm-mail-fetch.c
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail-server.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mailbox-list-iter.c
    M src/doveadm/doveadm-oldstats.c
    M src/doveadm/doveadm-print-formatted.c
    M src/doveadm/doveadm-print-table.c
    M src/doveadm/doveadm-who.c
    M src/doveadm/dsync/dsync-brain-mailbox.c
    M src/doveadm/dsync/dsync-brain.c
    M src/doveadm/dsync/dsync-ibc-stream.c
    M src/doveadm/dsync/dsync-mailbox-export.c
    M src/doveadm/dsync/dsync-mailbox-import.c
    M src/doveadm/dsync/dsync-transaction-log-scan.c
    M src/doveadm/server-connection.c
    M src/imap-login/imap-login-commands.c
    M src/imap-urlauth/imap-urlauth-client.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/cmd-getmetadata.c
    M src/imap/cmd-notify.c
    M src/imap/imap-commands.c
    M src/imap/imap-fetch.c
    M src/imap/imap-search.c
    M src/indexer/indexer-queue.c
    M src/ipc/ipc-group.c
    M src/lib-auth/auth-master.c
    M src/lib-auth/auth-server-connection.c
    M src/lib-dict-backend/dict-ldap-settings.c
    M src/lib-dict-backend/dict-sql-settings.c
    M src/lib-dict/dict-client.c
    M src/lib-dict/dict-memcached-ascii.c
    M src/lib-dict/dict-redis.c
    M src/lib-dict/dict.c
    M src/lib-fs/fs-api.c
    M src/lib-fts/fts-filter.c
    M src/lib-fts/fts-language.c
    M src/lib-fts/fts-tokenizer.c
    M src/lib-http/http-auth.c
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-client-peer.c
    M src/lib-http/http-client-queue.c
    M src/lib-http/http-client.c
    M src/lib-http/test-http-payload.c
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-msgmap.c
    M src/lib-imap-client/test-imapc-client.c
    M src/lib-index/mail-cache-lookup.c
    M src/lib-index/mail-index-map-hdr.c
    M src/lib-index/mail-index-map.c
    M src/lib-index/mail-index-strmap.c
    M src/lib-index/mail-index-sync-ext.c
    M src/lib-index/mail-index-transaction-update.c
    M src/lib-index/mail-index-transaction-view.c
    M src/lib-index/mail-index-transaction.c
    M src/lib-index/mail-index-view.c
    M src/lib-index/mail-index.c
    M src/lib-index/mail-transaction-log-view.c
    M src/lib-index/test-mail-index-transaction-finish.c
    M src/lib-lda/mail-deliver.c
    M src/lib-ldap/ldap-search.c
    M src/lib-mail/istream-attachment-connector.c
    M src/lib-mail/istream-header-filter.c
    M src/lib-master/master-service.c
    M src/lib-old-stats/stats.c
    M src/lib-program-client/program-client.c
    M src/lib-program-client/test-program-client-net.c
    M src/lib-program-client/test-program-client-unix.c
    M src/lib-sasl/dsasl-client.c
    M src/lib-settings/settings-parser.c
    M src/lib-smtp/smtp-client-command.c
    M src/lib-smtp/smtp-client-connection.c
    M src/lib-smtp/smtp-params.c
    M src/lib-smtp/smtp-reply-parser.c
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server-transaction.c
    M src/lib-smtp/smtp-submit.c
    M src/lib-smtp/test-smtp-payload.c
    M src/lib-sql/driver-cassandra.c
    M src/lib-sql/driver-test.c
    M src/lib-sql/sql-api.c
    M src/lib-storage/index/dbox-common/dbox-file.c
    M src/lib-storage/index/dbox-multi/mdbox-file.c
    M src/lib-storage/index/dbox-multi/mdbox-map.c
    M src/lib-storage/index/dbox-multi/mdbox-purge.c
    M src/lib-storage/index/dbox-multi/mdbox-save.c
    M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c
    M src/lib-storage/index/dbox-single/sdbox-save.c
    M src/lib-storage/index/dbox-single/sdbox-sync.c
    M src/lib-storage/index/imapc/imapc-mail-fetch.c
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/index-search.c
    M src/lib-storage/index/index-sort-string.c
    M src/lib-storage/index/index-sync-changes.c
    M src/lib-storage/index/index-thread-finish.c
    M src/lib-storage/index/maildir/maildir-uidlist.c
    M src/lib-storage/index/mbox/mbox-sync.c
    M src/lib-storage/list/mailbox-list-fs-iter.c
    M src/lib-storage/list/mailbox-list-index-notify.c
    M src/lib-storage/list/mailbox-list-iter.c
    M src/lib-storage/mail-namespace.c
    M src/lib-storage/mail-storage-hooks.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage.c
    M src/lib-storage/mailbox-list.c
    M src/lib-storage/mailbox-search-result.c
    M src/lib-storage/mailbox-tree.c
    M src/lib/ioloop.c
    M src/lib/istream-multiplex.c
    M src/lib/json-parser.c
    M src/lib/lib-event.c
    M src/lib/ostream-multiplex.c
    M src/lib/priorityq.c
    M src/lmtp/lmtp-local.c
    M src/lmtp/lmtp-proxy.c
    M src/master/service.c
    M src/plugins/acl/acl-api.c
    M src/plugins/acl/acl-backend-vfile-acllist.c
    M src/plugins/acl/acl-cache.c
    M src/plugins/acl/acl-lookup-dict.c
    M src/plugins/autocreate/autocreate-plugin.c
    M src/plugins/charset-alias/charset-alias-plugin.c
    M src/plugins/expire/doveadm-expire.c
    M src/plugins/expire/expire-set.c
    M src/plugins/fts-solr/fts-backend-solr.c
    M src/plugins/fts-solr/solr-connection.c
    M src/plugins/fts-squat/squat-uidlist.c
    M src/plugins/fts/fts-api.c
    M src/plugins/fts/fts-user.c
    M src/plugins/push-notification/push-notification-drivers.c
    M src/plugins/push-notification/push-notification-event-flagsclear.c
    M src/plugins/push-notification/push-notification-event-flagsset.c
    M src/plugins/push-notification/push-notification-events.c
    M src/plugins/push-notification/push-notification-plugin.c
    M src/plugins/push-notification/push-notification-txn-mbox.c
    M src/plugins/push-notification/push-notification-txn-msg.c
    M src/plugins/quota/quota-storage.c
    M src/plugins/quota/quota.c
    M src/plugins/virtual/virtual-config.c
    M src/plugins/virtual/virtual-mail.c
    M src/plugins/virtual/virtual-search.c
    M src/plugins/virtual/virtual-storage.c
    M src/plugins/virtual/virtual-sync.c
    M src/plugins/virtual/virtual-transaction.c
    M src/replication/replicator/replicator-brain.c
    M src/stats/stats-metrics.c
    M src/submission/submission-backend.c
    M src/submission/submission-client.c
    M src/submission/submission-recipient.c
    M src/util/script.c

  Log Message:
  -----------
  global: Use array_push_back

@@
expression A,I;
@@

-array_append(A, I, 1)
+array_push_back(A, I)

  Commit: 27b2b51943e0f9440483abeae4c9f5805b236db9
      https://github.com/dovecot/core/commit/27b2b51943e0f9440483abeae4c9f5805b236db9
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/auth/auth-request-handler.c
    M src/auth/auth-worker-server.c
    M src/auth/db-ldap.c
    M src/config/config-parser.c
    M src/dict/dict-commands.c
    M src/director/director.c
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/doveadm-dump-index.c
    M src/doveadm/doveadm-kick.c
    M src/doveadm/doveadm-mail-server.c
    M src/doveadm/doveadm-mailbox-list-iter.c
    M src/doveadm/doveadm-print-formatted.c
    M src/doveadm/doveadm-who.c
    M src/doveadm/dsync/dsync-ibc-pipe.c
    M src/doveadm/dsync/dsync-mailbox-export.c
    M src/imap/cmd-thread.c
    M src/imap/imap-commands-util.c
    M src/imap/imap-fetch.c
    M src/ipc/ipc-connection.c
    M src/ipc/ipc-group.c
    M src/lib-dict/dict-redis.c
    M src/lib-fts/fts-filter-normalizer-icu.c
    M src/lib-fts/fts-language.c
    M src/lib-http/http-client-connection.c
    M src/lib-http/http-message-parser.c
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-msgmap.c
    M src/lib-imap/imap-parser.c
    M src/lib-index/mail-index-sync-ext.c
    M src/lib-index/mail-index-transaction-update.c
    M src/lib-index/mail-index-view-sync.c
    M src/lib-index/mail-transaction-log-view.c
    M src/lib-lda/mail-deliver.c
    M src/lib-ldap/ldap-entry.c
    M src/lib-mail/istream-attachment-connector.c
    M src/lib-master/anvil-client.c
    M src/lib-smtp/smtp-reply-parser.c
    M src/lib-smtp/smtp-server-cmd-mail.c
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server-transaction.c
    M src/lib-sql/driver-cassandra.c
    M src/lib-sql/driver-test.c
    M src/lib-storage/index/dbox-multi/mdbox-purge.c
    M src/lib-storage/index/dbox-multi/mdbox-save.c
    M src/lib-storage/index/index-mail.c
    M src/lib-storage/index/index-search.c
    M src/lib-storage/index/index-sync-changes.c
    M src/lib-storage/index/index-thread-finish.c
    M src/lib-storage/index/pop3c/pop3c-client.c
    M src/lib/priorityq.c
    M src/master/service-process-notify.c
    M src/plugins/acl/acl-cache.c
    M src/plugins/fts-solr/solr-connection.c
    M src/plugins/fts/fts-expunge-log.c
    M src/plugins/mail-crypt/test-mail-global-key.c
    M src/plugins/quota/quota-imapc.c
    M src/plugins/virtual/virtual-sync.c
    M src/util/script.c

  Log Message:
  -----------
  global: Use array_first instead of array_idx

@@
expression A;
@@

-array_idx(A, 0)
+array_first(A)

@@
expression A;
@@

-array_idx_modifiable(A, 0)
+array_first_modifiable(A)

  Commit: bc8aaf310309f94f8b9638d32c2943fec6b4a70b
      https://github.com/dovecot/core/commit/bc8aaf310309f94f8b9638d32c2943fec6b4a70b
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/lib/array.h

  Log Message:
  -----------
  lib: array - Add helpers for dealing with some common array usecases

Adds macros for accessing first and last item, pushing and popping
and also adding/removing first item.

Note that pop and shift do not return item.

  Commit: 99cede4ba0a184e349cea1bb41b057e15b0495e8
      https://github.com/dovecot/core/commit/99cede4ba0a184e349cea1bb41b057e15b0495e8
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2019-01-10 (Thu, 10 Jan 2019)

  Changed paths:
    M src/lib/array.c
    M src/lib/array.h
    M src/lib/test-array.c

  Log Message:
  -----------
  lib: array - Fix asserts to work correctly on 32-bit systems

  Patch: https://github.com/dovecot/core/compare/70d18f189696...c5a99e78b625.patch


More information about the dovecot-cvs mailing list