[dovecot/core | refs/heads/master] d830785d: lib-smtp: server: Fix forwarding a multi-line reply.

[noreply at dovecot.org]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: d830785d4b235f869281d424fc773db7670d379d
      https://github.com/dovecot/core/commit/d830785d4b235f869281d424fc773db7670d379d
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M src/lib-smtp/smtp-server-reply.c

  Log Message:
  -----------
  lib-smtp: server: Fix forwarding a multi-line reply.

A multi-line reply had the '-' on the first line stripped upon sending, which
makes clients see two separate responses rather than just one. This was caused
by the fact that forwarded replies had the last_line field not set properly,
in which case the '-' was substituted on the first line, rather than the last.
The fix makes a forwarded reply indistinguishable from a normally created reply
by also allowing for amending the reply with additional lines using
smtp_server_reply_add_text().

  Commit: 865862013b5ef15950061d7bda3397c052287802
      https://github.com/dovecot/core/commit/865862013b5ef15950061d7bda3397c052287802
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M src/lib-smtp/test-smtp-reply.c

  Log Message:
  -----------
  lib-smtp: test-smtp-reply: Test whether parsed valid replies can be written back to the original input.

In some cases, the parser mangles the input a little to substitute invalid
characters. In those cases, the expected output is stated explicitly.

  Commit: c35a2b108e3d17a2d2fca92712e94e88b89b6656
      https://github.com/dovecot/core/commit/c35a2b108e3d17a2d2fca92712e94e88b89b6656
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2019-01-18 (Fri, 18 Jan 2019)

  Changed paths:
    M src/lib-smtp/Makefile.am
    D src/lib-smtp/test-smtp-reply-parser.c
    A src/lib-smtp/test-smtp-reply.c

  Log Message:
  -----------
  lib-smtp: Rename test-smtp-reply-parser.c to test-smtp-reply.c.

Encoding tests will also be included, making the old name confusing.

  Patch: https://github.com/dovecot/core/compare/c5dc617b26d0...d830785d4b23.patch