[Dovecot] Re: [dovecot-cvs] dovecot/src/lib fdpass.c,1.28,1.29

[Timo Sirainen]

On 15.6.2004, at 08:08, Charlie Allom wrote:

>>> imap-login: Jun 15 12:28:16 Panic: file ioloop.c: line 90: assertion
>>> failed: (i
>>> o->fd <= current_ioloop->highest_fd)

Hmm. Wonder why this hasn't happened more often. Good luck I guess. 
Pretty simple fix, I'll include with 0.99.10.6 too:

diff -u -r1.20 ioloop.c
--- ioloop.c    26 Aug 2003 21:18:16 -0000      1.20
+++ ioloop.c    19 Jun 2004 20:05:19 -0000
@@ -81,12 +81,12 @@
         /* notify the real I/O handler */
         io_loop_handle_remove(current_ioloop, io->fd, io->condition);

+       io->destroyed = TRUE;
+       io->fd = -1;
+
         /* check if we removed the highest fd */
         if (io->fd == current_ioloop->highest_fd)
                 update_highest_fd(current_ioloop);
-
-       io->destroyed = TRUE;
-       io->fd = -1;
  }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://dovecot.org/pipermail/dovecot/attachments/20040619/f05e7131/attachment-0001.bin>