[Dovecot] Misbehavior with Dovecot and Mulberry

[Timo Sirainen]

On Mon, 2005-09-05 at 23:57 -0500, Jon Roma wrote:
>     --> #6.3408 Mon Sep  5 23:25:13 2005
>     A00092 APPEND Sent (\Seen) {610+}
>     A00092 NO

That happens if some function returned -1 but didn't set any error.
Shouldn't happen..

> I am running 1.0-test80 with Timo's patch to fix the "time off by
> 200 minutes" error with mbox.  All my folders are maildir at this
> point -- I've converted them out of my UW mbx format store.  My
> client is Mulberry 3.1.6 for Windows and the OS is AIX 5.1.

So, they are maildirs? Do these changes help:

Index: src/imap/cmd-append.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/imap/cmd-append.c,v
retrieving revision 1.64
retrieving revision 1.65
diff -u -r1.64 -r1.65
--- src/imap/cmd-append.c	28 Jun 2005 11:15:57 -0000	1.64
+++ src/imap/cmd-append.c	18 Sep 2005 16:58:01 -0000	1.65
@@ -292,8 +292,7 @@
 	int failed;
 
 	if (ctx->save_ctx != NULL) {
-		if (mailbox_save_continue(ctx->save_ctx) < 0 ||
-		    client->input->closed) {
+		if (mailbox_save_continue(ctx->save_ctx) < 0) {
 			/* we still have to finish reading the message
 			   from client */
 			mailbox_save_cancel(ctx->save_ctx);
Index: src/lib-storage/index/maildir/maildir-save.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/lib-storage/index/maildir/maildir-save.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -r1.57 -r1.58
--- src/lib-storage/index/maildir/maildir-save.c	14 Aug 2005 19:02:54 -0000	1.57
+++ src/lib-storage/index/maildir/maildir-save.c	18 Sep 2005 16:58:31 -0000	1.58
@@ -217,6 +217,10 @@
 		return -1;
 
 	if (o_stream_send_istream(ctx->output, ctx->input) < 0) {
+		mail_storage_set_critical(STORAGE(ctx->mbox->storage),
+			"o_stream_send_istream(%s) failed: %m",
+			t_strconcat(ctx->tmpdir, "/",
+				    ctx->files->basename, NULL));
 		ctx->failed = TRUE;
 		return -1;
 	}

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20050918/b2ac52e1/attachment-0001.pgp