[Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

[Steffen Kaiser]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

Dovecot v1.0.0

if there is no Return-Path in the message and Deliver cannot deliver the 
message, no DSN is sent _and_ the MTA is returned 0 (aka success) return 
code, which leads to mail loss.

This is not the case, when the message actually finds a Return-Path, but 
fails to invoke the MTA.

- --- src/deliver/mail-send.c (revision 47)
+++ src/deliver/mail-send.c (working copy)
@@ -42,7 +42,7 @@
             i_info("msgid=%s: Return-Path missing, rejection reason: %s",
                    orig_msgid == NULL ? "" : str_sanitize(orig_msgid, 80),
                    str_sanitize(reason, 512));
- -           return 0;
+           return EX_TEMPFAIL;
      }

      smtp_client = smtp_client_open(return_addr, NULL, &f);

Bye,

- -- 
Steffen Kaiser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRkGA0S9SORjhbDpvAQIh0Qf/RUkmWnK+LhB3/ZwY+AnyTAYGBPB7qTCp
bVchn4F7zL+W2fIYZGz6YG1bKUtHE3qMQAY3gYijspNZBejS0Z8cTI983ZMwJFP+
ygMAicyEDFSWrFWYnzBnpvHYZEK9VjQ4HnDIkojDQx+pQH0LS/Ve0/JbiaNuwMRQ
g0ay3puas8xiyktRHVHslDfbanrfzwpbO7qtNpFrF9aCKo3RLIhFCKSjaXD75BfQ
K7XrmOjFECkB1bLeaFJrVzm/DoayRn1HusKQjtwKCRx4YBgOP0d5OQGQTvqRLx33
agHXdNxFN6vYB/QbIMcoI6xyWw6POHpiRjLJ5maWsdhlMFIrRVNOJg==
=xshk
-----END PGP SIGNATURE-----