[Dovecot] Dovecot crashes with malformed Qpopper's mbox

[Timo Sirainen]

On 24.5.2007, at 17.53, MAEDA, Go wrote:

>> If you're interested in fixing it yourself I can give a bit of  
>> help :)
>
>   Thanks. I'll try to fix it myself. Please give me advice.
>   The function I have to modify is _read() in istream-raw-mbox.c,  
> isn't
> it? And need to add some code to skip duplicated "From " separator,  
> I guess.

Yep. I think the way to do this right is:

  - Instead of requiring "\n[\r]From ", require "\n[\r]\n[\r]From "
  - in mbox-save.c make sure that the extra empty line is always  
added (I'm not sure if this already is done, I think it isn't)
  - preferrably also fix broken mboxes in mbox-sync.c and mbox- 
save.c: If you notice that it doesn't end with two linefeeds, add one  
or two so it does

The optional CRs are a bit annoying to handle correctly..

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20070524/fb8854be/attachment.bin