[Dovecot] syslog with PID

[Heiko Schlichting]

Hi,

LOG_NDELAY is the only option for openlog() in dovecot 1.1.2. 
Wouldn't be
LOG_NDELAY|LOG_PID as option parameter much more useful? 
Without logging
the pid, it is impossible to match 'Disconnected' log entries and the
corresponding session start/login. Therefore I suggest to use

    LOG_NDELAY|LOG_PID

in the options of i_set_failure_syslog() at all 6 occurrences which passes
it to openlog().

I know that it is possible to
    - use logging to file
    - patch it myself
but I can't see good reasons in not using LOG_PID here. As far as I know,
most other programs specify LOG_PID.

Without LOG_PID:
Jul 31 10:21:08 name dovecot: IMAP(hsg): Disconnected: Logged out bytes=28/242

With LOG_PID:
Jul 31 10:21:08 name dovecot[17016]: IMAP(hsg): Disconnected: Logged out bytes=28/242

Heiko

Heiko Schlichting          Freie Universität Berlin
heiko at FU-Berlin.DE         Zentraleinrichtung für Datenverarbeitung (ZEDAT)
Telefon +49 30 838-54327   Fabeckstraße 32
Telefax +49 30 838454327   14195 Berlin