[Dovecot] typo in failures.c

[Johannes Berg]

On Sat, 2008-06-07 at 05:11 +0300, Timo Sirainen wrote:
> On Fri, 2008-06-06 at 21:00 -0500, Mike Abbott wrote:
> > Hi, I found a typo on line 101 of dovecot-1.1.rc8/src/lib/failures.c.   
> > The first two arguments to io_add() are reversed.  The fd should be  
> > first, and IO_WRITE second.
> 
> Thanks, fixed: http://hg.dovecot.org/dovecot-1.1/rev/7c9895192a23
> 
> I wish gcc warned about bad enum usages, it would have caught this.

The Linux kernel uses sparse(1) to catch this kind of thing, but it may
require some annotations. Cf.
http://www.kernel.org/pub/software/devel/sparse/

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20080608/a3d4fd24/attachment.bin