[Dovecot] URLAUTH assertion failures in 2.2.1

[Mike Abbott]

Testing URLAUTH in dovecot-2.2.1 plus Timo's recent CATENATE and URLAUTH fixes eventually trips some assertions.  No simple sequence of commands always hits these; they appear to be timing-dependent.

The first one is:

May 02 17:47:17 imap(pid 50490 user submit): Panic: file imap-client.c: line 643 (client_command_free): assertion failed: (client->output_cmd_lock == NULL)

The line number doesn't match dovecot-2.2.1 due to Apple's unrelated modifications.

0   libsystem_kernel.dylib        	0x00007fff8a9f7d4a __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff8f728705 pthread_kill + 92
2   libsystem_c.dylib             	0x00007fff8f48b17b abort + 125
3   libdovecot.0.dylib            	0x000000010db8d2bb default_fatal_finish + 68
4   libdovecot.0.dylib            	0x000000010db8df66 i_internal_error_handler + 0
5   libdovecot.0.dylib            	0x000000010db8d53d i_panic + 158
6   imap                          	0x000000010da468fe client_command_free + 446
7   imap                          	0x000000010da47a33 client_output_cmd + 37
8   imap                          	0x000000010da46497 client_output + 143
9   libdovecot.0.dylib            	0x000000010dba5610 stream_send_io + 53
10  libdovecot.0.dylib            	0x000000010db9bc74 io_loop_call_io + 46
11  libdovecot.0.dylib            	0x000000010db9cc85 io_loop_handler_run + 214
12  libdovecot.0.dylib            	0x000000010db9be1f io_loop_run + 77
13  libdovecot.0.dylib            	0x000000010db5b0c6 master_service_run + 24
14  imap                          	0x000000010da4fa66 main + 1010
15  libdyld.dylib                 	0x00007fff8f7887bd start + 1

The second one is:

May 02 19:23:29 imap(pid 60229 user mja): Panic: file index-mail.c: line 1274 (index_mail_close_streams_full): assertion failed: (!mail->data.destroying_stream)

0   libsystem_kernel.dylib        	0x00007fff8a9f7d4a __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff8f728705 pthread_kill + 92
2   libsystem_c.dylib             	0x00007fff8f48b17b abort + 125
3   libdovecot.0.dylib            	0x00000001054c42bb default_fatal_finish + 68
4   libdovecot.0.dylib            	0x00000001054c4f66 i_internal_error_handler + 0
5   libdovecot.0.dylib            	0x00000001054c453d i_panic + 158
6   libdovecot-storage.0.dylib    	0x00000001053aaebb index_mail_close_streams_full + 199
7   libdovecot-storage.0.dylib    	0x00000001053aaf29 index_mail_close + 44
8   libdovecot-storage.0.dylib    	0x00000001053ab6bd index_mail_free + 48
9   libdovecot-storage.0.dylib    	0x000000010538a19a mail_free + 15
10  libdovecot-storage.0.dylib    	0x00000001053dd3b3 imap_msgpart_url_free + 65
11  imap                          	0x000000010532d563 imap_urlauth_fetch_abort_local + 30
12  imap                          	0x000000010532cb96 imap_urlauth_fetch_abort + 38
13  imap                          	0x000000010532cb54 imap_urlauth_fetch_deinit + 24
14  imap                          	0x00000001053218bd cmd_urlfetch_finish + 45
15  imap                          	0x0000000105321aa3 cmd_urlfetch_continue + 167
16  imap                          	0x0000000105323ef8 command_exec + 55
17  imap                          	0x0000000105323a20 client_output_cmd + 18
18  imap                          	0x0000000105322497 client_output + 143
19  libdovecot.0.dylib            	0x00000001054dc610 stream_send_io + 53
20  libdovecot.0.dylib            	0x00000001054d2c74 io_loop_call_io + 46
21  libdovecot.0.dylib            	0x00000001054d3c85 io_loop_handler_run + 214
22  libdovecot.0.dylib            	0x00000001054d2e1f io_loop_run + 77
23  libdovecot.0.dylib            	0x00000001054920c6 master_service_run + 24
24  imap                          	0x000000010532ba66 main + 1010
25  libdyld.dylib                 	0x00007fff8f7887bd start + 1