[PATCH 0/7] Fixes for lib-mail message-address

Timo Sirainen tss at iki.fi
Thu Apr 7 13:11:12 UTC 2016


On 06 Apr 2016, at 17:29, Pali Rohár <pali.rohar at gmail.com> wrote:
> 
> On Monday 04 April 2016 19:35:22 Pali Rohár wrote:
>> On Monday 04 April 2016 19:31:06 aki.tuomi at dovecot.fi wrote:
>>> Can you please send them directly to me, please?
>>> ---
>>> Aki Tuomi
>> 
>> Sent.
> 
> Received? Are patches OK now?

It would be nice if each commit was accompanied with the corresponding unit test change in test-message-address.c. Now that the unit test changes are done in a separate commit I'm not really sure which test change is testing which commit or if some tests are missing. At least the "Quote and escape strings if needed" patch needs more tests for different kinds of escapes/atext/non-atext chars and =? in strings.



More information about the dovecot mailing list