v2.2.28: var-expand.c

Timo Sirainen tss at iki.fi
Sun Feb 26 13:54:46 UTC 2017


On 26 Feb 2017, at 14.44, Ruga <ruga at protonmail.com> wrote:
> 
> var-expand.c:687:17: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> 
> 
> va_start(args, key2);
> 
> 
> ^
> 
> 
> var-expand.c:674:58: note: parameter of type 'char' is declared here
> 
> 
> var_expand_table_build(char key, const char *value, char key2, ...)
> 
> 
> ^

Yeah, the API is just bad. That function is removed from v2.3 already. I didn't want to break v2.2 backwards compatibility.



More information about the dovecot mailing list