use instance-name for syslog?

A. Schulze sca at andreasschulze.de
Thu May 31 22:29:27 EEST 2018



Am 31.05.2018 um 20:40 schrieb Timo Sirainen:
> 
>> On 30 May 2018, at 19.08, SATOH Fumiyasu <fumiyas at osstech.co.jp> wrote:
>> I have a patchset to implement that. Please see the attachment.
>> Subject: [PATCH 1/2] master: Do not prepend "dovecot-" to a process name
> 
> Why not? I'd think it would be useful to always find dovecot processes.
for exactly that reason I also skipped that part of the patch

> 
>> -	openlog(ident, options, facility);
>> +	static char *syslog_ident = NULL;
>> +
>> +	i_free(syslog_ident);
>> +	syslog_ident = i_strdup(ident);
>> +
>> +	openlog(syslog_ident, options, facility);
> 
> 
> I don't think this is necessary?
> 
>> +		env_put(t_strconcat("INSTANCE_NAME=", set->instance_name, NULL));
> 
> 
> Also not needed.
> 
> But yeah, I guess in general it would make sense to use instance_name for syslog ident.

I'm pretty sure you could tweak the patch. Good to see, you agree in general.

Andreas


More information about the dovecot mailing list