[bug] success field never emited in auth_request_finished event

[Jean-Daniel Dupas]

Hi,

I'm playing with the new events, and encounter some issues:

First the 'auth_request_finished' event is documented as having a 'successful' field, but in the code, the field is defined as 'success' (e->add_str("success", "yes")).

But more important, in the function "auth_request_success_continue()" (auth/auth-request.c:288), "auth_request_log_finished(request)"  is call (line 303) before updating the request status: "request->successful = TRUE" (line 312)

So the log function never set the success field to "yes" as at this point request->successful is still false.

Jean-Daniel