Dovecot release v2.3.7

[Timo Sirainen]

On 12 Jul 2019, at 21.05, Michael Grimm via dovecot <dovecot at dovecot.org> wrote:
> 
> Aki Tuomi via dovecot <dovecot at dovecot.org> wrote:
> 
>> We are pleased to release Dovecot release v2.3.7.
> 
> My upgrade from 2.3.6 to 2.3.7 broke replication (FreeBSD 12.0-STABLE r349799):
> 
> | dovecot[76032]: master: Dovecot v2.3.7 (494d20bdc) starting up for imap, lmtp, sieve
> | dovecot[76035]: replicator: Error: file_ostream.net_set_tcp_nodelay((conn:unix:/var/run/dovecot/stats-writer), TRUE) failed: Invalid argument
> | dovecot[76035]: replicator: Error: file_ostream.net_set_tcp_nodelay((conn:unix:auth-userdb), TRUE) failed: Invalid argument
> | dovecot[76035]: auth: Error: file_ostream.net_set_tcp_nodelay((conn:unix:/var/run/dovecot/stats-writer), TRUE) failed: Invalid argument

I don't think these cause any actual breakage? Of course, there are tons of errors logged..

This likely fixes it anyway:

diff --git a/src/lib/ostream-file.c b/src/lib/ostream-file.c
index e7e6f62d1..766841f2f 100644
--- a/src/lib/ostream-file.c
+++ b/src/lib/ostream-file.c
@@ -334,7 +334,7 @@ static void o_stream_tcp_flush_via_nodelay(struct file_ostream *fstream)
 {
        if (net_set_tcp_nodelay(fstream->fd, TRUE) < 0) {
                if (errno != ENOTSUP && errno != ENOTSOCK &&
-                   errno != ENOPROTOOPT) {
+                   errno != ENOPROTOOPT && errno != EINVAL) {
                        i_error("file_ostream.net_set_tcp_nodelay(%s, TRUE) failed: %m",
                                o_stream_get_name(&fstream->ostream.ostream));
                }