Incorrect value sent to solr

[John Fawcett]

On 07/04/2021 13:36, Łukasz Szczepański wrote:
> I'm not as familiar with C, but I don't see in solr backed in dovecot
> any  clue of subsequent queries for single mailbox lookup (which most
> mail client uses). There is a hard limit of 100000 rows for multiple
> mailbox lookup.


This was reported back in December 2020. I submitted this fix to the
list on 31/12/2020 to give an upper bound for single mailbox queries as
there is in place for multiple mailbox queries.

diff -ur dovecot-2.3.11.3-orig/src/plugins/fts-solr/fts-backend-solr.c
dovecot-2.3.11.3/src/plugins/fts-solr/fts-backend-solr.c

--- dovecot-2.3.11.3-orig/src/plugins/fts-solr/fts-backend-solr.c      
2020-08-12 14:20:41.000000000 +0200
+++ dovecot-2.3.11.3/src/plugins/fts-solr/fts-backend-solr.c   
2020-12-31 09:05:07.681897716 +0100
@@ -838,7 +838,7 @@

        str = t_str_new(256);
        str_printfa(str,
"wt=xml&fl=uid,score&rows=%u&sort=uid+asc&q=%%7b!lucene+q.op%%3dAND%%7d",
-                   status.uidnext);
+                   I_MIN(status.uidnext,SOLR_MAX_MULTI_ROWS));
        prefix_len = str_len(str);

        if (solr_add_definite_query_args(str, args, and_args)) {