<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><div>You copied your Makefile.am there. Stephan made you a working version, can you try that?</div><div><br></div><div>(sorry for dup)</div><div><br></div><div>Aki</div><div><br></div><div style="font-size:100%;color:#000000"><!-- originalMessage --><div>-------- Original message --------</div><div>From: Joan Moreau <jom@grosjo.net> </div><div>Date: 13/01/2019 21:39 (GMT+02:00) </div><div>To: Stephan Bosch <stephan@rename-it.nl> </div><div>Cc: Aki Tuomi <aki.tuomi@open-xchange.com> </div><div>Subject: Re: [FTS Xapian] Beta release </div><div><br></div></div>
<p>I used the skeleton from Aki : <a href="https://github.com/grosjo/fts-xapian">https://github.com/grosjo/fts-xapian</a></p>
<p>However, when I try to act as a visitor, I reach teh follwoing error:</p>
<p># autoreconf -vi<br>autoreconf: Entering directory `.'<br>autoreconf: configure.ac: not using Gettext<br>autoreconf: running: aclocal -I m4<br>autoreconf: configure.ac: tracing<br>autoreconf: running: libtoolize --copy<br>libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.<br>libtoolize: copying file './ltmain.sh'<br>libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.<br>libtoolize: copying file 'm4/libtool.m4'<br>libtoolize: copying file 'm4/ltoptions.m4'<br>libtoolize: copying file 'm4/ltsugar.m4'<br>libtoolize: copying file 'm4/ltversion.m4'<br>libtoolize: copying file 'm4/lt~obsolete.m4'<br>autoreconf: running: /usr/bin/autoconf<br>autoreconf: running: /usr/bin/autoheader<br>autoreconf: running: automake --add-missing --copy --no-force<br>configure.ac:9: installing './compile'<br>configure.ac:11: installing './config.guess'<br>configure.ac:11: installing './config.sub'<br>configure.ac:7: installing './install-sh'<br>configure.ac:7: installing './missing'<br>src/Makefile.am: installing './depcomp'<br>/usr/share/automake-1.16/am/depend2.am: error: am__fastdepCXX does not appear in AM_CONDITIONAL<br>/usr/share/automake-1.16/am/depend2.am: The usual way to define 'am__fastdepCXX' is to add 'AC_PROG_CXX'<br>/usr/share/automake-1.16/am/depend2.am: to 'configure.ac' and run 'aclocal' and 'autoconf' again<br>src/Makefile.am: error: C++ source seen but 'CXX' is undefined<br>src/Makefile.am: The usual way to define 'CXX' is to add 'AC_PROG_CXX'<br>src/Makefile.am: to 'configure.ac' and run 'autoconf' again.<br>src/Makefile.am:11: warning: variable 'NOPLUGIN_LDFLAGS' is defined but no program or<br>src/Makefile.am:11: library has 'NOPLUGIN' as canonical name (possible typo)<br>autoreconf: automake failed with exit status: 1</p>
<p><br></p>
<div id="signature"> </div>
<p><br></p>
<p id="reply-intro">On 2019-01-13 20:24, Stephan Bosch wrote:</p>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<div class="pre" style="margin: 0; padding: 0; font-family: monospace">Oh, right, a distribution tarball doesn't include some of the necessary files for your repository like autogen.sh and .gitignore. The attached tarball includes all those and is ready for `git init`. The previous tarball was made with `make distcheck` from this one.<br><br><span style="white-space: nowrap;">Regards,</span><br><br><span style="white-space: nowrap;">Stephan.</span><br><br><span style="white-space: nowrap;">Op 13/01/2019 om 20:14 schreef Stephan Bosch:</span>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><span style="white-space: nowrap;">Hi Joan,</span><br><br><span style="white-space: nowrap;">Op 13/01/2019 om 19:03 schreef Aki Tuomi:</span>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><span style="white-space: nowrap;">Yes, from compiling point of view it is done.</span><br><br>Unfortunately what is not done is all the other work involved, such as fixing all the inevitable bugs it has and maintaining it. We do not want, at this moment, take up maintaining and developing yet another FTS plugin as we have plenty of things to do already.<br><br>I invite you to setup your own repository and provide this plugin from there, being the maintainer of this plugin. We can add a link to your plugin on our FTS page so people can also find it.<br><br>There are other plugins like this, e.g. <a href="https://github.com/st3fan/dovecot-xaps-plugin" target="_blank" rel="noopener noreferrer">https://github.com/st3fan/dovecot-xaps-plugin</a></blockquote>
<br>I turned the code you provided into a separate plugin package. The distribution tarball is attached.<br><br><span style="white-space: nowrap;">Notable changes:</span><br><br>- Added example copyright headers and COPYING and AUTHORS files. You should modify those to your preference.<br>- Added README and INSTALL files (in markdown using Pandoc). Those need to be amended with details.<br>- Amended the plugin code to display a debug message with the plugin name and version upon plugin load.<br><br><span style="white-space: nowrap;">I advise you to turn this into a git repository and continue from there.</span><br><br>I do not recommend releasing this plugin with the -fpermissive flag and the resulting warning as it is now. But I'm assuming this is still a work in progress, so that is OK.<br><br><span style="white-space: nowrap;">Regards,</span><br><br><span style="white-space: nowrap;">Stephan.</span><br><br><br>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><span style="white-space: nowrap;">On 13 January 2019 at 19:52 Joan Moreau <<a href="mailto:jom@grosjo.net" rel="noreferrer">jom@grosjo.net</a>> wrote:</span><br><br><br>The only point here of this fts-xapian is to get rid of solr (because it<br><span style="white-space: nowrap;">is just a nightmare to setup) and squat (because it is considere</span><br><span style="white-space: nowrap;">obsolete).</span><br><br><span style="white-space: nowrap;">I already sent the changed in configure.ac, makefile.am, etc.. in order</span><br><span style="white-space: nowrap;">to include it in the dovecot, and it compiles properly</span><br><br><span style="white-space: nowrap;">The only remaining point is to push it in hte git (yes, everything is</span><br><span style="white-space: nowrap;">already done)</span><br><br><span style="white-space: nowrap;">On 2019-01-13 18:45, Aki Tuomi wrote:</span><br><br>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">On 13 January 2019 at 17:05 Joan Moreau via dovecot <<a href="mailto:dovecot@dovecot.org" rel="noreferrer">dovecot@dovecot.org</a>> wrote:<br><br>Hi<br><br>Please find attached the beta release of FTS Xapian, with the objective<br><span style="white-space: nowrap;">to replace fts_squat that is being deprecated.</span><br><br><span style="white-space: nowrap;">Configuration is exactly the same as for fts_squat:</span><br><br><span style="white-space: nowrap;">plugin {</span><br><br><span style="white-space: nowrap;">plugin = fts fts_xapian (...)</span><br><span style="white-space: nowrap;">fts = xapian</span><br><span style="white-space: nowrap;">fts_autoindex = yes</span><br><span style="white-space: nowrap;">fts_enforced = yes</span><br><span style="white-space: nowrap;">fts_xapian = partial=2 full=20</span><br><br>This is installed on my production server (>120Gb of mailboxes), and I<br><span style="white-space: nowrap;">will observe it during the coming days.</span><br><br><span style="white-space: nowrap;">I will definitely appreciate that this is added in the core git of</span><br>docevot, in order to have a versionning of it, to remove squat and let<br><span style="white-space: nowrap;">basic users able to avoid Solr alternative as much as possible.</span><br><br>Thanks<br><br>JM</blockquote>
<span style="white-space: nowrap;">Hi!</span><br><br>I still recommend you setup a, say, github repository for your plugin. We are not able to currently include your work in dovecot core as it is more work than just pushing the code into the repo. Maybe it can be included in the future.<br><br>If you want, I can help you in setting up the required configuration scripts and such to make it possible to compile it as plugin.<br><br>Then anyone can download it and install it for their dovecot, even if dovecot itself has been installed from packages, and also makes it possible for package maintainers to consider including it in distributions.<br><br>Aki</blockquote>
</blockquote>
</blockquote>
</blockquote>
</div>
</blockquote>
</body></html>