<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 28.5.2019 22.34, mabi via dovecot
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7rfkn06Qj-wDFnSHMVBwvnBvtSnlapY8MrcufzhDyvAXDOSrAsXWTptZhj7eiG0UJGQ5vB-yCbPhD25vWiCtmuiW4qxgsmTNV67Jr8Pct-4=@protonmail.ch">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐<br>
</div>
<div> On Monday, May 20, 2019 12:37 AM, John Fawcett via dovecot
<a class="moz-txt-link-rfc2396E" href="mailto:dovecot@dovecot.org"><dovecot@dovecot.org></a> wrote:<br>
</div>
<div> <br>
</div>
<blockquote class="protonmail_quote" type="cite">
<p>there's no field name that is obviously the primary key. I've
reworked the patch to use the postgres default primary key
constraint name (tablename_pkey). <br>
</p>
<p>The attached fix should work in that case, although I feel
it's not general enough.<br>
</p>
</blockquote>
<div>I saw there has been quite some discussion how to make things
more generic and better for database queries in general in
Dovecot around my issue but I would still be very thankful if
your original patch could be submitted to Dovecot for review and
approval. Your patch solves an immediate problem which is of
adding UPSERT functionality to PostgreSQL Dict queries.<br>
</div>
<div><br>
</div>
<div>MySQL Dict queries has its "INSERT ... ON DUPLICATE KEY
UPDATE" implemented in Dovecot so I think it's more than fair
that for now that PostgreSQL support in Dict also gets its
equivalent "INSERT ... ON CONFLICT UPDATE" implemented.<br>
</div>
<div><br>
</div>
<div>This is just my opinion as a long-time "user" of Dovecot, I
am no dev...<br>
</div>
</blockquote>
<p>We'll take this under consideration, but no promises.</p>
<p>Aki<br>
</p>
</body>
</html>