<html>
<head>
<style type="text/css">
body,p,td,div,span{
font-size:14px;font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
};
body p{
margin:0px;
}
</style>
</head>
<body>But do you know how this bug was introduced ?<div><br></div><div>I checked the history of that file and don't see anything introduced recently that might cause this: <a href="https://github.com/dovecot/core/commits/master/src/lib-http/http-client-request.c" class="normal-link normal-link-url" target="_blank" rel="noopener noreferrer">https://github.com/dovecot/core/commits/master/src/lib-http/http-client-request.c</a></div><div><br></div><div>The only one that might be somewhat related is this one from Apr 27 by Stephan Bosch</div><div><br></div><div><a href="https://github.com/dovecot/core/commit/799b52accf71e86756dde738d22c1c6a500a7e29#diff-1c02b3481573ffd33c9abccd3f5a6752a5cd81ca83389f4380657f7309c06366" class="normal-link normal-link-url" target="_blank" rel="noopener noreferrer">https://github.com/dovecot/core/commit/799b52accf71e86756dde738d22c1c6a500a7e29#diff-1c02b3481573ffd33c9abccd3f5a6752a5cd81ca83389f4380657f7309c06366</a></div><div><br></div><div><br><br>On Saturday, 31/10/2020 at 08:40 John Fawcett wrote:<br><blockquote style="border:0;border-left: 2px solid #22437f; padding:0px; margin:0px; padding-left:5px; margin-left: 5px; ">
<div class="moz-cite-prefix">On 31/10/2020 00:18, Scott Q. wrote:<br>
</div>
<blockquote type="cite" cite="mid:eef949e0948322198a97ef66369e88f3@polarismail--com.w.emailarray.com">
I have implemented this change and the core dumps went away.
<div><br>
</div>
<div>It appears so far that it's indeed the right fix.</div>
<div><br>
</div>
<div>Has this change been introduced in 2.3.11.3 ? </div>
<div><br>
</div>
<div>Thanks!</div>
</blockquote>
<p>I've also been running it for 4 days without any further panics /
segfaults and no noticed adverse effects. I'd recommend the
dovecot team to consider including the patch in the next update.</p>
<p>John</p>
<p>diff -ur dovecot-2.3.11.3-orig/src/lib-http/http-client-request.c
dovecot-2.3.11.3/src/lib-http/http-client-request.c<br>
--- dovecot-2.3.11.3-orig/src/lib-http/http-client-request.c
2020-08-12 14:20:41.000000000 +0200<br>
+++ dovecot-2.3.11.3/src/lib-http/http-client-request.c 2020-10-27
13:06:09.352973130 +0100<br>
@@ -1229,12 +1229,12 @@<br>
const char *error;<br>
uoff_t offset;<br>
<br>
- i_assert(req->payload_input != NULL);<br>
- i_assert(req->payload_output != NULL);<br>
-<br>
if (req->payload_finished)<br>
return
http_client_request_finish_payload_out(req);<br>
<br>
+ i_assert(req->payload_input != NULL);<br>
+ i_assert(req->payload_output != NULL);<br>
+<br>
io_remove(&conn->io_req_payload);<br>
<br>
/* chunked ostream needs to write to the parent stream's
buffer */</p>
</blockquote></div></body></html>