<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /></head><body style='font-size: 9pt; font-family: Verdana,Geneva,sans-serif'>
<p>Yes, it seems fixed with this patch :)</p>
<p><br /></p>
<p>Another bug with git, is the "type=" in systemd is switched from "simple" to "notify". The later does not work and reverting to "simple" does work</p>
<div id="signature"></div>
<p><br /></p>
<p id="reply-intro">On 2021-04-25 17:53, Aki Tuomi wrote:</p>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">
<div class="pre" style="margin: 0; padding: 0; font-family: monospace">
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">On 24/04/2021 21:56 Joan Moreau <<a href="mailto:jom@grosjo.net">jom@grosjo.net</a>> wrote:<br /><br /><br />chroot= does not resolve the issue<br />I have "chroot = login" in my conf<br /><br /></blockquote>
<br />Thanks!<br /><br />The chroot was needed to get the core dump.<br /><br />Can you try if this does fix the crash?<br /><br />Aki<br /><br />From 1df4e02cbff710ce8938480b07a5690e37f661f6 Mon Sep 17 00:00:00 2001<br />From: Timo Sirainen <<a href="mailto:timo.sirainen@open-xchange.com">timo.sirainen@open-xchange.com</a>><br />Date: Fri, 23 Apr 2021 16:43:36 +0300<br />Subject: [PATCH] login-common: Fix handling destroyed_clients linked list<br /><br />The client needs to be removed from destroyed_clients linked list before<br />it's added to client_fd_proxies linked list.<br /><br />Broken by 1c622cdbe08df2f642e28923c39894516143ae2a<br />---<br /> src/login-common/client-common.c | 11 +++++++----<br /> 1 file changed, 7 insertions(+), 4 deletions(-)<br /><br />diff --git a/src/login-common/client-common.c b/src/login-common/client-common.c<br />index bdb6e9c798..1d264d9f75 100644<br />--- a/src/login-common/client-common.c<br />+++ b/src/login-common/client-common.c<br />@@ -289,8 +289,9 @@ void client_disconnect(struct client *client, const char *reason,<br /> /* Login was successful. We may now be proxying the connection,<br /> so don't disconnect the client until client_unref(). */<br /> if (client->iostream_fd_proxy != NULL) {<br />+ i_assert(!client->fd_proxying);<br /> client->fd_proxying = TRUE;<br />- i_assert(client->prev == NULL && client->next == NULL);<br />+ DLLIST_REMOVE(&destroyed_clients, client);<br /> DLLIST_PREPEND(&client_fd_proxies, client);<br /> client_fd_proxies_count++;<br /> }<br />@@ -307,8 +308,9 @@ void client_destroy(struct client *client, const char *reason)<br /> <br /> if (last_client == client)<br /> last_client = client->prev;<br />- /* remove from clients linked list before it's added to<br />- client_fd_proxies. */<br />+ /* move to destroyed_clients linked list before it's potentially<br />+ added to client_fd_proxies. */<br />+ i_assert(!client->fd_proxying);<br /> DLLIST_REMOVE(&clients, client);<br /> DLLIST_PREPEND(&destroyed_clients, client);<br /> <br />@@ -409,13 +411,14 @@ bool client_unref(struct client **_client)<br /> DLLIST_REMOVE(&client_fd_proxies, client);<br /> i_assert(client_fd_proxies_count > 0);<br /> client_fd_proxies_count--;<br />+ } else {<br />+ DLLIST_REMOVE(&destroyed_clients, client);<br /> }<br /> i_stream_unref(&client->input);<br /> o_stream_unref(&client->output);<br /> i_close_fd(&client->fd);<br /> event_unref(&client->event);<br /> <br />- DLLIST_REMOVE(&destroyed_clients, client);<br /> i_free(client->proxy_user);<br /> i_free(client->proxy_master_user);<br /> i_free(client->virtual_user);</div>
</blockquote>
</body></html>