[dovecot/core] 8a2f21: lib-dcrypt: Avoid infinite loop if istream header ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 8a2f21f2b03878918333efac486f99e4fa0ecce2
      https://github.com/dovecot/core/commit/8a2f21f2b03878918333efac486f99e4fa0ecce2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  lib-dcrypt: Avoid infinite loop if istream header is too large.

We'll return an error now instead. We can't just return -2 here, because nothing
was actually being returned to the caller. Attempting to do that would just trigger
an assert:

Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos)