[dovecot/core] 8dfdcd: doveadm-server: Reset error code between calls

GitHub noreply at github.com
Tue Sep 6 16:30:17 UTC 2016


  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 8dfdcd15772931a6d768adb40ea4094b68eb218a
      https://github.com/dovecot/core/commit/8dfdcd15772931a6d768adb40ea4094b68eb218a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/doveadm/client-connection.c

  Log Message:
  -----------
  doveadm-server: Reset error code between calls


  Commit: cfb4971cccca2ef18a45e7a5d3e5069c90df9422
      https://github.com/dovecot/core/commit/cfb4971cccca2ef18a45e7a5d3e5069c90df9422
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/lib-fs/fs-metawrap.c
    M src/lib-fs/fs-randomfail.c
    M src/lib-fs/fs-sis-queue.c
    M src/lib-fs/fs-sis.c
    M src/lib-fs/fs-wrapper.c
    M src/plugins/fs-compress/fs-compress.c

  Log Message:
  -----------
  lib-fs: Do not abort parent of parent


  Commit: 2e7a0190d94de727a012616c13566ba9e9973554
      https://github.com/dovecot/core/commit/2e7a0190d94de727a012616c13566ba9e9973554
  Author: Phil Carmody <phil at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/director/login-connection.c
    M src/lib/file-lock.c

  Log Message:
  -----------
  Fix control flow and T_BEGIN/T_END hygiene

You mustn't goto, break, continue, or return from out of a
T_BEGIN {...} T_END block, as that will lose a t_pop().
This has been seen in the wild: Panic: Leaked t_pop() call

Signed-off-by: Phil Carmody <phil at dovecot.fi>


  Commit: 527d6c592aec1e3db5d6cd4205328b73f3047dd9
      https://github.com/dovecot/core/commit/527d6c592aec1e3db5d6cd4205328b73f3047dd9
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c

  Log Message:
  -----------
  dcrypt: Allow stream prefetch

We might get stream that has already been buffered, so we
must try read it in case buffer is full.


  Commit: b5d604ba1775dbb841ec367724eb61b19d14a3e3
      https://github.com/dovecot/core/commit/b5d604ba1775dbb841ec367724eb61b19d14a3e3
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  dcrypt: Test for stream prefetch


  Commit: 6a008d83f39981731372fd24b6653af674a33448
      https://github.com/dovecot/core/commit/6a008d83f39981731372fd24b6653af674a33448
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/lib-dcrypt/istream-decrypt.c
    M src/lib-dcrypt/test-stream.c

  Log Message:
  -----------
  lib-dcrypt: Avoid infinite loop if istream header is too large.

We'll return an error now instead. We can't just return -2 here, because nothing
was actually being returned to the caller. Attempting to do that would just trigger
an assert:

Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos)


Compare: https://github.com/dovecot/core/compare/0204e1fcc053...6a008d83f399


More information about the dovecot-cvs mailing list