[dovecot/core] 077b35: lib-lda: smtp-client: Renamed "smtp_client" parame...

Mon Mar 27 10:00:15 UTC 2017

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: 077b350ebf3542424b31693ccc6f2fc7d4524f98
      https://github.com/dovecot/core/commit/077b350ebf3542424b31693ccc6f2fc7d4524f98
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-lda/smtp-client.c

  Log Message:
  -----------
  lib-lda: smtp-client: Renamed "smtp_client" parameters to "client" for consistency.

  Commit: 14a37c403acfe3e7f040f1aab37f70a2b3cc1379
      https://github.com/dovecot/core/commit/14a37c403acfe3e7f040f1aab37f70a2b3cc1379
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-lda/smtp-client.c

  Log Message:
  -----------
  lib-lda: smtp-client: Make sure only the first error determines the tempfail status.

The client is supposed to stop running the moment the first error occurs. However, there is a (very unlikely) possiblity that the encapsulated LMTP client issues both an RCPT and DATA error callback in sequence.
In that case, the second callback should not override the tempfail status of the first (the second likely is a tempfail).
If the server disconnects right after failing the last of at least two recipients, the lmtp-client would issue a DATA callback with a disconnection error.
The disconnect error would set the client->tempfail flag, which caused smtp_client_deinit*() to always return -1 in this scenario.

  Commit: a3a4c12c35a38fe5008fe2001fa73b5bb82e7371
      https://github.com/dovecot/core/commit/a3a4c12c35a38fe5008fe2001fa73b5bb82e7371
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-smtp/lmtp-client.c

  Log Message:
  -----------
  lib-smtp: lmtp-client: Fixed bug in timeout handling.

The timeout was erroneously stopped when lmtp_client_send() was invoked before a connection was established.
Once the connection finally got established, the timeout was removed.
This would cause the client to wait indefinitely.

  Commit: 17084e30a4a316ec2f3a765f5bb4936d65367493
      https://github.com/dovecot/core/commit/17084e30a4a316ec2f3a765f5bb4936d65367493
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-lda/smtp-client.c

  Log Message:
  -----------
  lib-lda: smtp-client: Fixed cleanup of LMTP client at end of transaction.

It was not deinitialized, causing a memory leak.

  Commit: e8a8ae03e6c87211d32eec10778a055119174b5b
      https://github.com/dovecot/core/commit/e8a8ae03e6c87211d32eec10778a055119174b5b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-lda/smtp-client.c

  Log Message:
  -----------
  lib-lda: smtp-client: Fixed memory leak of the error message string.

  Commit: 37f0284ba928733361c4ba77570e03883ea2dce1
      https://github.com/dovecot/core/commit/37f0284ba928733361c4ba77570e03883ea2dce1
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/doveadm/doveadm-cmd.c
    M src/doveadm/doveadm.h

  Log Message:
  -----------
  doveadm: Add exit code/string conversion functions

  Commit: 0a812a18bab1acfc42e84cb45b2cd99846a10332
      https://github.com/dovecot/core/commit/0a812a18bab1acfc42e84cb45b2cd99846a10332
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/doveadm/client-connection.c
    M src/doveadm/server-connection.c

  Log Message:
  -----------
  doveadm: Send and receive exit codes correctly

The old code would assume TEMPFAIL for almost everything.

  Commit: 07b307039b497a8acea6082a577544176b02b86e
      https://github.com/dovecot/core/commit/07b307039b497a8acea6082a577544176b02b86e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: test-http-client-errors: Always use the proper error status code definitions rather than an integer literal.

  Commit: f6d2025b8039a12c09cdc3fd517e84b9cb54d3b9
      https://github.com/dovecot/core/commit/f6d2025b8039a12c09cdc3fd517e84b9cb54d3b9
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client.h
    M src/lib-http/http-response.h

  Log Message:
  -----------
  lib-http: Explicitly define the start of the range of internal response status codes.

  Commit: a474158382b6f33757116e0a349236b2617655db
      https://github.com/dovecot/core/commit/a474158382b6f33757116e0a349236b2617655db
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-response.h

  Log Message:
  -----------
  lib-http: Added a function to obtain a message suitable for logging from a response object.

This prevents logging internal error codes (>= 9000).

  Commit: 6da637fe37eb76ae2ace3a42bc0df45498ec8dce
      https://github.com/dovecot/core/commit/6da637fe37eb76ae2ace3a42bc0df45498ec8dce
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/auth/auth-policy.c
    M src/lib-http/http-client-connection.c
    M src/plugins/fts-solr/solr-connection.c
    M src/plugins/fts/fts-parser-tika.c
    M src/plugins/push-notification/push-notification-driver-ox.c

  Log Message:
  -----------
  global: Use http_response_get_message() to log HTTP responses.

  Commit: 62852b807f32600d71425aedbf10eb84be8ce9fc
      https://github.com/dovecot/core/commit/62852b807f32600d71425aedbf10eb84be8ce9fc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: test-http-client-errors: Added test for using https:// while SSL is not configured.

  Commit: 4d57187d09661340e1a01ea90a075c1346cdaff6
      https://github.com/dovecot/core/commit/4d57187d09661340e1a01ea90a075c1346cdaff6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: client: Clear request pointer immediately in http_client_request_error().

  Commit: 7b846290fb429af258c0082384f30b1eb70a4828
      https://github.com/dovecot/core/commit/7b846290fb429af258c0082384f30b1eb70a4828
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.c

  Log Message:
  -----------
  lib-http: client: Restructured the handling of delayed errors.

The req->delayed_error* fields are cleared before the callback is called and before the request is dereferenced.
This way, freeing the request never removes it from the delayed request list when the list is being processed.
It also makes it possible to resubmit the request from the callback (mainly for future use).

  Commit: 452cc7b2087431d505dad50ad1e0e5bc0faaac1a
      https://github.com/dovecot/core/commit/452cc7b2087431d505dad50ad1e0e5bc0faaac1a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client-request.c

  Log Message:
  -----------
  lib-http: client: Make sure a request's log label never gets a duplicate request target part.

Make sure the URL part of the label always only consists of a http://host:port part and nothing more.

  Commit: 06a7484862f3f911bd36911e4e533ca193699046
      https://github.com/dovecot/core/commit/06a7484862f3f911bd36911e4e533ca193699046
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.h
    M src/lib-http/test-http-client-errors.c

  Log Message:
  -----------
  lib-http: client: Implemented http_client_request_url_str() function that accepts an URL string rather than a pre-parsed URL object.

If the provided HTTP URL is invalid, the callback with the error is called some time later from the ioloop.
This change also amends the test-http-client-errors test suite with a new test for this new feature.

  Commit: 7c75172b93b1adb0a9e113dae92741325e8bf41f
      https://github.com/dovecot/core/commit/7c75172b93b1adb0a9e113dae92741325e8bf41f
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-fts/Makefile.am
    M src/lib/Makefile.am

  Log Message:
  -----------
  lib: Download unicode.org files from dovecot.org

  Commit: 99b77f8e57396a1fcb45ba6163b48ab57d646d4e
      https://github.com/dovecot/core/commit/99b77f8e57396a1fcb45ba6163b48ab57d646d4e
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/mailbox-list-private.h
    M src/lib-storage/mailbox-list.c
    M src/lib-storage/mailbox-list.h

  Log Message:
  -----------
  lib-storage: Add mailbox_list_get_last_internal_error()

This returns the error given to mailbox_list_set_critical().

  Commit: 0e7af5e64e1c3ff9e8ed6940687d2fecb9a02e41
      https://github.com/dovecot/core/commit/0e7af5e64e1c3ff9e8ed6940687d2fecb9a02e41
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/doveadm/doveadm-mail-index.c
    M src/doveadm/doveadm-mail-mailbox.c
    M src/doveadm/doveadm-mail.c
    M src/doveadm/doveadm-mailbox-list-iter.c
    M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
    M src/doveadm/dsync/dsync-mailbox-tree-fill.c
    M src/imap/main.c
    M src/lib-imap-urlauth/imap-urlauth-backend.c
    M src/lib-storage/list/mailbox-list-index-backend.c
    M src/lib-storage/mail-autoexpunge.c
    M src/plugins/quota/quota-count.c
    M src/plugins/virtual/virtual-config.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Log mailbox_list internal errors

  Commit: 08e468540bff9d538f7cbe1b8be6aa5f7d53bd7b
      https://github.com/dovecot/core/commit/08e468540bff9d538f7cbe1b8be6aa5f7d53bd7b
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/Makefile.am
    A src/lib-dict/dict-fail.c
    M src/lib-dict/dict-private.h

  Log Message:
  -----------
  lib-dict: Add dict-fail driver

It can be used for providing various failures

  Commit: 9cce4519d6d71c5c0ac1814eb1c0ba75ef19133d
      https://github.com/dovecot/core/commit/9cce4519d6d71c5c0ac1814eb1c0ba75ef19133d
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/dict.c

  Log Message:
  -----------
  dict: Update correct counter in dict_iterate_init

  Commit: a0053e52a3d62322f8b630258f4ec7179c1e4e7e
      https://github.com/dovecot/core/commit/a0053e52a3d62322f8b630258f4ec7179c1e4e7e
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/dict.c

  Log Message:
  -----------
  lib-dict: Use dict-fail iterator and transaction when missing from dict driver

  Commit: 6440a342205737dbc3a9d5c88b32a500c7f54902
      https://github.com/dovecot/core/commit/6440a342205737dbc3a9d5c88b32a500c7f54902
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/Makefile.am

  Log Message:
  -----------
  lib-dict: Fix test-dict linkage

  Commit: 57906900c186c27941771874536c388019b69d33
      https://github.com/dovecot/core/commit/57906900c186c27941771874536c388019b69d33
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/dict-private.h
    M src/lib-dict/dict.c

  Log Message:
  -----------
  lib-dict: Track transaction counts

  Commit: 884394237744c0ab2da558e471a67dbe270f86ca
      https://github.com/dovecot/core/commit/884394237744c0ab2da558e471a67dbe270f86ca
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-dict/dict.c

  Log Message:
  -----------
  lib-dict: Ensure all iterations and transactions are done in deinit

  Commit: 09b0bde688a00eaebb76f998b0f59d18296b0238
      https://github.com/dovecot/core/commit/09b0bde688a00eaebb76f998b0f59d18296b0238
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/plugins/acl/acl-mailbox-list.c

  Log Message:
  -----------
  acl: Use mailbox_list_context instead of ctx->ctx

This prepares for the next commit

  Commit: f9586610b32f9fa488f987cfe2c1c1208cb189b5
      https://github.com/dovecot/core/commit/f9586610b32f9fa488f987cfe2c1c1208cb189b5
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/plugins/acl/acl-mailbox-list.c

  Log Message:
  -----------
  acl: Use MODULE_CONTEXT for mailbox list iterator

  Commit: e8878afb91d5247de037afffcdb3505ae1a81bfd
      https://github.com/dovecot/core/commit/e8878afb91d5247de037afffcdb3505ae1a81bfd
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c
    M src/lib-storage/mailbox-list-private.h

  Log Message:
  -----------
  lib-storage: Expose mailbox_list_init_autocreate

It is needed when backend_ctx is created on the fly

  Commit: 6f1f9bac6c909efda241ea929af5bd52e756abeb
      https://github.com/dovecot/core/commit/6f1f9bac6c909efda241ea929af5bd52e756abeb
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/list/mailbox-list-fs-iter.c
    M src/lib-storage/list/mailbox-list-index-iter.c
    M src/lib-storage/list/mailbox-list-iter.c
    M src/lib-storage/list/mailbox-list-maildir-iter.c
    M src/lib-storage/list/mailbox-list-subscriptions.c
    M src/lib-storage/mailbox-list-private.h

  Log Message:
  -----------
  lib-storage: Add and use default mailbox iterator

The idea is to allow mail plugins to see also the non-existent
autoboxes by feeding them thru the iterator.

Fixes problem where autocreated boxes are not seen by ACL
plugin.

  Commit: ff271fae9e12a424a3bce19cf0b23f64a434e383
      https://github.com/dovecot/core/commit/ff271fae9e12a424a3bce19cf0b23f64a434e383
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2017-03-27 (Mon, 27 Mar 2017)

  Changed paths:
    M src/lib/var-expand.c

  Log Message:
  -----------
  lib: Fix whitespace in var-expand.c

Compare: https://github.com/dovecot/core/compare/fcb3ccff65b4...ff271fae9e12