[dovecot/core] 188cc2: imapc: Ignore fetch-msn-workarounds/no-msn-updates...

[GitHub]

  Branch: refs/heads/master-2.3
  Home:   https://github.com/dovecot/core
  Commit: 188cc2cde8ef27cfb3fa9d941d5243763dbf0321
      https://github.com/dovecot/core/commit/188cc2cde8ef27cfb3fa9d941d5243763dbf0321
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Ignore fetch-msn-workarounds/no-msn-updates during initial FETCH

Otherwise duplicate UIDs aren't detected and it causes an assert-crash:

Panic: file imapc-mailbox.c: line 533 (imapc_untagged_fetch): assertion failed: (lseq == mbox->sync_next_lseq)


  Commit: d2d399fa347ebb619b6a7f021f2a8cb7fa381f73
      https://github.com/dovecot/core/commit/d2d399fa347ebb619b6a7f021f2a8cb7fa381f73
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix crash when untagged FETCH reply doesn't have key-value pairs

The last key with the missing value is just silently ignored.


  Commit: 4e881e9eee34c6d1f08332aa70f25b6af74bf041
      https://github.com/dovecot/core/commit/4e881e9eee34c6d1f08332aa70f25b6af74bf041
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: If SELECT INBOX fails with NO, treat it as temporary failure

If it's treated as "mailbox doesn't exist", the INBOX autocreation code
will attempt to CREATE INBOX. This is very unlikely to work.


  Commit: 6d138888011b4785d97ec91caebdfcb75e48d232
      https://github.com/dovecot/core/commit/6d138888011b4785d97ec91caebdfcb75e48d232
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix local state if mailbox is empty after reconnection

If local indexes had more than 0 mails, but after reconnection the remote
IMAP server replied with "* 0 EXISTS", the mails in local index weren't
expunged. This could have resulted in:

Panic: file imapc-sync.c: line 328 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq) || seq_range_exists(&ctx->mbox->delayed_expunged_uids, luid))


  Commit: b01048358d3b5f0edbbc928ca6c38d226a5356e1
      https://github.com/dovecot/core/commit/b01048358d3b5f0edbbc928ca6c38d226a5356e1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix crash when handling empty mailboxes.

Broken by c05b4ac76c4c6012958f1cc37e2fccf7a7d31c33


Compare: https://github.com/dovecot/core/compare/c8efc7e504f1...b01048358d3b