[dovecot/core] bd66b8: imapc: Ignore fetch-msn-workarounds/no-msn-updates...

[GitHub]

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: bd66b8184cedc38ed67f4beac07b29ab4cd97359
      https://github.com/dovecot/core/commit/bd66b8184cedc38ed67f4beac07b29ab4cd97359
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Ignore fetch-msn-workarounds/no-msn-updates during initial FETCH

Otherwise duplicate UIDs aren't detected and it causes an assert-crash:

Panic: file imapc-mailbox.c: line 533 (imapc_untagged_fetch): assertion failed: (lseq == mbox->sync_next_lseq)


  Commit: 3e164c2e44db3dc0b6ab42233996d4fffe9d4cdd
      https://github.com/dovecot/core/commit/3e164c2e44db3dc0b6ab42233996d4fffe9d4cdd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix crash when untagged FETCH reply doesn't have key-value pairs

The last key with the missing value is just silently ignored.


  Commit: 7571273a5497c3283938115721b04bba6c29fec8
      https://github.com/dovecot/core/commit/7571273a5497c3283938115721b04bba6c29fec8
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: If SELECT INBOX fails with NO, treat it as temporary failure

If it's treated as "mailbox doesn't exist", the INBOX autocreation code
will attempt to CREATE INBOX. This is very unlikely to work.


  Commit: 056929a1c64d5cb07fcc4336ef9a5aa187f849e3
      https://github.com/dovecot/core/commit/056929a1c64d5cb07fcc4336ef9a5aa187f849e3
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix local state if mailbox is empty after reconnection

If local indexes had more than 0 mails, but after reconnection the remote
IMAP server replied with "* 0 EXISTS", the mails in local index weren't
expunged. This could have resulted in:

Panic: file imapc-sync.c: line 328 (imapc_initial_sync_check): assertion failed: (mail_index_is_expunged(view, lseq) || seq_range_exists(&ctx->mbox->delayed_expunged_uids, luid))


  Commit: c1564df392deb82253f07a806f1756706b4c9d4a
      https://github.com/dovecot/core/commit/c1564df392deb82253f07a806f1756706b4c9d4a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-mailbox.c

  Log Message:
  -----------
  imapc: Fix crash when handling empty mailboxes.

Broken by c05b4ac76c4c6012958f1cc37e2fccf7a7d31c33


Compare: https://github.com/dovecot/core/compare/bdb1c133b502...c1564df392de