[dovecot/core] 81c895: lib-smtp: address parser: Do not allow source rout...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 81c8955e3d1475c6ab1892b1d3edf91126683fda
      https://github.com/dovecot/core/commit/81c8955e3d1475c6ab1892b1d3edf91126683fda
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/smtp-address.c
    M src/lib-smtp/test-smtp-address.c

  Log Message:
  -----------
  lib-smtp: address parser: Do not allow source route for path with omitted brackets.

Parse it strictly as a Mailbox, which makes more sense.


  Commit: 6b16d3e04ef68a67390b31fbd18d714aaaa4528f
      https://github.com/dovecot/core/commit/6b16d3e04ef68a67390b31fbd18d714aaaa4528f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-mail.c
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: Add workarounds for well-known MAIL and RCPT command syntax deviations.


  Commit: e52c7366cfa2d5e4f5006e3a719e5b5b12d8668c
      https://github.com/dovecot/core/commit/e52c7366cfa2d5e4f5006e3a719e5b5b12d8668c
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Use o_stream_nsend*() rather than o_stream_send*().

The result is not checked anyway.


  Commit: a690a5a435ab25d9afd8f4d33563501f31fac528
      https://github.com/dovecot/core/commit/a690a5a435ab25d9afd8f4d33563501f31fac528
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add support for client-side connection context data.


  Commit: 0185e80ba6593fea4920e2e08431ce8b2470c2fe
      https://github.com/dovecot/core/commit/0185e80ba6593fea4920e2e08431ce8b2470c2fe
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add log prefixes for client and server.

Makes it easier to distinguish which process is sending a log message while
debugging.


  Commit: dcde0acb1a9249f82c912ca9137650d0ce858dcc
      https://github.com/dovecot/core/commit/dcde0acb1a9249f82c912ca9137650d0ce858dcc
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Make detection of early termination of child processes part of each test.


  Commit: fe0d54c255693737d786a0feb7bbc03f30c534ff
      https://github.com/dovecot/core/commit/fe0d54c255693737d786a0feb7bbc03f30c534ff
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add more debug messages for the server.


  Commit: be82b9f8fe185c3ea27d4d4618782edc5f818be3
      https://github.com/dovecot/core/commit/be82b9f8fe185c3ea27d4d4618782edc5f818be3
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Implicitly stop server when all expected client connections are closed.


  Commit: 531fddd53f8e588213c5b235e3c6599909fee523
      https://github.com/dovecot/core/commit/531fddd53f8e588213c5b235e3c6599909fee523
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for bad MAIL command syntax.


  Commit: 1f1deb95b7e16f0bbaf31d0eb10410f858d6a071
      https://github.com/dovecot/core/commit/1f1deb95b7e16f0bbaf31d0eb10410f858d6a071
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for bad RCPT command syntax.


  Commit: cd019aedf2a95a7f98ca2c855dd2be05e644d080
      https://github.com/dovecot/core/commit/cd019aedf2a95a7f98ca2c855dd2be05e644d080
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for MAIL command workarounds.


  Commit: 698d821ac81990b2a764c6401214cbd391e91f89
      https://github.com/dovecot/core/commit/698d821ac81990b2a764c6401214cbd391e91f89
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: test-smtp-server-errors: Add tests for RCPT command workarounds.


  Commit: b639f5330017eba3d2819f66e93ecc78b17ea17b
      https://github.com/dovecot/core/commit/b639f5330017eba3d2819f66e93ecc78b17ea17b
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M doc/example-config/conf.d/20-submission.conf
    M src/submission/submission-client.c
    M src/submission/submission-settings.c
    M src/submission/submission-settings.h

  Log Message:
  -----------
  submission: Add workarounds for well-known MAIL and RCPT command syntax deviations.

This adds a new `submission_client_workarounds' setting that works analogous to
the `imap_client_workarounds' setting.

Workarounds:

- whitespace-before-path: Allow one or more spaces or tabs between `MAIL FROM:'
                    and path and between `RCPT TO:' and path.
- mailbox-for-path:       Allow using bare Mailbox syntax (i.e., without <...>)
                    instead of full path syntax.


Compare: https://github.com/dovecot/core/compare/bb249b86d5e4...b639f5330017