[Dovecot] Hierarchy separator usage -- and a bijou bug? (was: Prayer, Maildir and Folders whose names begin with ".")

[Timo Sirainen]

On Tue, 2007-03-13 at 18:51 +0200, Timo Sirainen wrote:
> On Tue, 2007-03-13 at 16:45 +0000, Mike Brudenell wrote:
> 
> >      File:       src/imap/commands-util.c
> >      Function:   client_verify_mailbox_name()
> 
> A better place would be src/lib-storage/index/maildir/maildir-storage.c
> maildir_is_valid_create_name().

Uh. No, actually you can't do it there because you wanted to check
against '.'. So yes, your original location was correct.

> > I'm confused how client_verify_mailbox_name() is detecting two or  
> > more of either "." or "/" as the code looks to only check one  
> > separator character (obtained from mail_storage_get_hierarchy_sep 
> > (storage))
> > 
> > Or is this returning the separator character maildir is using (".")  
> > and not the hierarchy separator which we have changed in the Dovecot  
> > configuration file to "/"?  If so then my code fragment isn't going  
> > to work, as the Maildir filestore separator will continue to be "." :-(
> 
> That code is only verifying the separator from namespace configuration.

And this is wrong too.. It should be verifying the separator from
namespace configuration, but it isn't. I'll fix that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20070313/c8d3785e/attachment.pgp